[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 12/12] x86/trace: Clean up trace handling


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Tue, 21 Sep 2021 19:34:48 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ddGu/6OK1sBG/G8q1B+cUaTB/vRhwOjCZyqPZ/DTBSM=; b=ckLfnLtWl8QkZqLmp1hSMWCsZIj5pKtkVL/UE8JwQesLiZsaAu0WqVbCsu4R+Rcdp8oY32TZ/NOMufAl+FNnVkvWJFjXdzX4Vlh8L7HraOvVLNOmxcg/Qe2oiI0Pw642tB5Vc9v6SzpCPOpcDEEBOWp9NvNY21OxrccXRuuihY5aWA3uMfZJVMxDHClNj/AsC7q8+WwU9RiR35s9EbW2VaMKSyetD5KW5DhArm0Pd8XC/l/1VG2j0X7dGDLQpp7UXnn9UQAAEBDxHDuVvkV3hU5ca8FHjkO3GJhzl1+XROzpfFnjmZmXLl7YGcrjpGQejW74+1mXnapruhrha4RvZA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jpx/hpUcdiBkMxcB5GulAYLB64sxjBgdvjzO3Uu5FiO30DzYnH66hJHxm1lx72Nt0DLRWl/zQdToK2urNDstCxXdDuxYR0IfgsFuK+Vd797hmDTNqHzE3atY7HL9+2yAlvgapcy7dR0IXI1PFD06waxryhRAqnVEWt3cusYRSaFXVxdZl4we7uS9s7remhgGN77Qirxxpuyi+PhdYp/mZjaXGzRorFQHkhK/SEYS1eqfHHQH1//CADBsH9XzzG0qq1FKGa4OWYTtu4Mmrosf/MDVMIm5K7q2YdXEMSDnLlGKeVqqfACV55QNsGRdxYEz+mH2UXAdE64AMX8jd/sO2g==
  • Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Tue, 21 Sep 2021 18:35:08 +0000
  • Ironport-data: A9a23:8v7IwK5NPyLw+UbQ5M6nLQxRtB3AchMFZxGqfqrLsTDasY5as4F+v jYdCGiAOPuDYGOmeo1xb9++phhVu5ODz4djHFdsriBgHi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FVIMpBsJ00o5wrZo2Ncw27BVPivW0 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z5 I5hvLOyEB8QAvecovg8XQRxLSdDBPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr 7pCcmlLN03dwbLtqF64YrAEasALBc/nJo4A/FpnyinUF60OSpHfWaTao9Rf2V/cg+gTRqiBP 5RBOFKDajzgeExyEwsoFKs8xr3vhCHjVRYBlHOa8P9fD2/7k1UqjemF3MDuUt6ASNhRn02Yj nnb5Gm/CRYfXPSAzRKV/3TqgfXA9QvrVYRXGLCm+/pChFyI2ndVGBAQTUG8o/Sylgi5Qd03F qAP0nNw9+5orhXtF4SjGU3jyJKZgvICc/YLP+QV6liV85aOszyFJ2YZZwBHVeVz4afaWgcWO k+1c8LBXGI06uTFFy7Fr994vhvpZnNEdjZqiTssCFJfuoi9+tlbYgfnE447eJNZmOEZDt0ZL 9qilyE4m7xbpsoCzazTEbvv0m/0+8ShouLY4GzqsoOZAuFRP9XNi2+AswGzARN8wGGxFALpg ZT8s5LChN3i9LnU/MB3fAnoIIxFGt7faGGM6bKQI3XR32v0oCPyFWyhyBp/OF1oIq45RNMdW 2eK4Vk5zMYKZBOCNPYrC6rsW5VC5fWxTrzNC6GLBueil7AsLWdrCgk1PhXOt40s+WBx+ZwC1 WCzK5f0USlCVvQ5k1JbhY41iNcW+8z3/kuKLbjTxBW7y7uOInmTTLYOKlyVae4lqqiDpW3oH xx3bKNmEj1TD7/zZDf564kWIQxYJHQ3H8mu+cdWavSCMkxtH2R4U63dxrYoeopEmaVJl7iXo iHhCxEAkFev12faLQiqa2x4bO+9V5hIsn9mbzcnOkyl2iZ/bN/3vrsfbZY+YZIu6PdnkaxvV /AAdsjZWqZPRz3L9i4zd574qIA+Jh2niRjXZ3iuYSQlfo4mTAvMo4e2cgzq/SgILyy2qcph/ OHwilKFGcIOHl0wAtzXZfSjy0KKkUIcwO8iDVHVJtRzeVn39NQ4ISLGkfJqcdoHLg/Ox2XG2 l/OUwsYv+TEv6Q87MLN2fKft46sHuZzQhhaEm3c4erkPCXW5DP+k4pJUeLOdjHBTmLkvq6lY LwNnf37NfQGmndMspZ9TOk3nf5vuYO3qu8I1BlgEVXKc0+vW+FpLXSx1MVSsrFAm+1CsgysV 0PTotRXNN1l4i8+/IL98Ob9Utm+6A==
  • Ironport-hdrordr: A9a23:yEq0waw//2uU24l13qB/KrPwIr1zdoMgy1knxilNoH1uHvBw8v rEoB1173DJYVoqNk3I++rhBEDwexLhHPdOiOF6UItKNzOW21dAQrsSiLfK8nnNHDD/6/4Y9Y oISdkbNDQoNykZsfrH
  • Ironport-sdr: yB2/bV/RSp5kNm/+gJ6v/NZEfHk/xHIOAtXikvThKhlqQqjGxAyvUYpBgH0g7qApK9wxVT/XpY PQmo9xdFfyOCXL6PpRKs/SaTqiJ19AvEuZ/f6j43pp56LnatbCsZOxkWAjvVW6EH1VmEF+fJVf bMf6XQ51uIWxWXMVAF+1IVD/keOOyqPg6IlRInDngW2iTr3iU6L6SgqTVaWM/bChvxQrmJzYuW OuKKR3TYlM2VHl/M48QMf5bDCxXQFtOiPs6R6cKKwnz+T748OABcrDhdCtB3+00iSuh1J1fqW1 FXSSU4qdo6/AluBMCulhS4Zz
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 21/09/2021 17:08, Jan Beulich wrote:
> On 20.09.2021 19:25, Andrew Cooper wrote:
>> Use more appropriate types.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Thanks.

> with a suggestion:
>
>> @@ -48,30 +45,28 @@ void __trace_pv_page_fault(unsigned long addr, unsigned 
>> error_code)
>>  
>>      if ( is_pv_32bit_vcpu(current) )
>>      {
>> -        struct __packed {
>> -            u32 eip, addr, error_code;
>> -        } d;
>> -
>> -        d.eip = eip;
>> -        d.addr = addr;
>> -        d.error_code = error_code;
>> +        struct {
>> +            uint32_t eip, addr, error_code;
>> +        } d = {
>> +            .eip = eip,
>> +            .addr = addr,
>> +            .error_code = error_code,
>> +        };
>>  
>>          __trace_var(TRC_PV_PAGE_FAULT, 1, sizeof(d), &d);
>>      }
>>      else
>>      {
>>          struct __packed {
>> -            unsigned long eip, addr;
>> -            u32 error_code;
>> -        } d;
>> -        unsigned event;
>> -
>> -        d.eip = eip;
>> -        d.addr = addr;
>> -        d.error_code = error_code;
>> -        event = TRC_PV_PAGE_FAULT;
>> -        event |= TRC_64_FLAG;
>> -        __trace_var(event, 1, sizeof(d), &d);
>> +            uint64_t eip, addr;
> Like you've done in __trace_pv_trap() and __trace_ptwr_emulation(),
> perhaps name the field "rip" here as well?

Fixed.  (Honestly - these all start to blur together given how large the
series is.)

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.