[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/3] xen/privcmd: drop "pages" parameter from xen_remap_pfn()
- To: Jan Beulich <jbeulich@xxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
- From: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
- Date: Wed, 22 Sep 2021 10:02:12 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=vjKfXFb7ybIVhkg0g69KskKhyPpx49YcvOPdtRFCrm4=; b=Pe7zvmIwzilfbYq+pNXncD2MMOe6GLnvb+Yjb9CE839wXrrFhxIJojte9wdVtPiSIqYBS7ZP0bKABP3bNjSVFozkWO3T/ZFmWkgvifA0evYahQwOaFKdfq3SztbEWiorAuqCZ5WiQISxPE3sArE8aZc0K6+lQAnjK7+00C3wYJufXNEt3JEozpLCwzYJDmxYIQkoqVBLu32kl6+bSkSnABfn/uNhPKW1uxiilp34ZmSKmgdEj9uXsl9ZGX+GxWlbB5u5k69AoX0REWH2o1M8Xlas3pIRdHHYm5nk+Ut2j6Dv7TZ5sK+ZNJqG/T99A1FYD7Sy5K/sB+E0IBMO5j4kkw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kdKKwC6YsgBgQOggfkWZb9AjEgJKzAHxt36FmH7wOtNeSVOXKpwYbFonFkMBmDw+qP0lNk2GzAhdFDg8J6geKD/6Q30TYBIWs5J16vOmj9t00pPcivQBaOIFmMune/Mz0bUE1R4YnKYh2P4MRG7ODKr/EMlfqu884IRPTHSZbI4GlUGf90auZ7QIizP3UhdLxa5/WuJrtgeUmAj9nFJ7YzEfndbvZJ7BGfD2Xm5j750gSE5qGEal56f1LIL+RnPefIm8WnhYF6gQqI9ol+zLppgRpEmI7S6wiWntTDtEsCS/33z6oCRXAwBcUGBTB8ilpMu7uU+MdejQPoeC2BcBeg==
- Authentication-results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=oracle.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, lkml <linux-kernel@xxxxxxxxxxxxxxx>
- Delivery-date: Wed, 22 Sep 2021 14:02:35 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 9/22/21 6:18 AM, Jan Beulich wrote:
> The function doesn't use it and all of its callers say in a comment that
> their respective arguments are to be non-NULL only in auto-translated
> mode. Since xen_remap_domain_mfn_array() isn't supposed to be used by
> non-PV, drop the parameter there as well. It was bogusly passed as non-
> NULL (PRIV_VMA_LOCKED) by its only caller anyway. For
> xen_remap_domain_gfn_range(), otoh, it's not clear at all why this
> wouldn't want / might not need to gain auto-translated support down the
> road, so the parameter is retained there despite now remaining unused
> (and the only caller passing NULL); correct a respective comment as
> well.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
|
