[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 4/9] x86/PVH: provide VGA console info to Dom0
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Wed, 22 Sep 2021 18:03:57 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=5felQb1LbNmrt3F2TUVttsNTPHqdtjORDBVW1/xao/U=; b=GUzh1i7dPeS8AVhaALhOy7AYi6rx34b/clI7JBo1cZZNBJBlQc48gtwc1AKBd6Pk2sJOZdhQeBQQz/Ki4a/18pGbkPZjvUVz1V2oTBIwXwf9BIhvQ8mVFoJDEPpE9hp6Fnh6sLFcpCSP/XMMvA5qFt3HG48Ej2VzQBdpOoR5D88gnSk99xGpW6WTez2SshVDnWXI/ZkQ/ApBQeNh/Q9pcAV5TXQ8MNXbQHvUhjTNU4WQqybhLYDTCC1JAnOk5JdOt4me2KZ1bQWopTgbAHccIS1uP9qz0V6kf7jZwrYEmCVdZ8okwxZEeHRr9A8rrFhztb0bnwn93Cg5RnWlbthtQQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G/MjnQ3T0dogiV0shKGY9asCKQ8PGzG5EVVtNia3SPK37D2wDsd51MuFD01iPXYqNv8P7CBwZkpDtEoAoeWCXIcXtIegTBRLET6HZGvagNLFPu5nNwttVutz4G8BXXedAzIPONB67fDY+eFyJbwiym/RB5Qpu0pv64UExcdTuUuofjd+cKKIbyViChBy0oof7IW/ASRiPTppQr6O6BG4ItYaDDB2vzs1kl1G7vb/j7e75QriiNrV42LA2KqFEpU9ASSY7AChOkoXj+bLzJ33MF1yM/hJ2jHwkzf3IoJDh0U2LU86bHQBe6iFy5h2xzvOs4d8Qjhrc+qp51dKgsvnRg==
- Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Wed, 22 Sep 2021 17:05:35 +0000
- Ironport-data: A9a23:HSdbEKuT7KXyfauYnMZZqR7mfOfnVGVZMUV32f8akzHdYApBsoF/q tZmKTqFa6mONDfwet9+bI60o0hVu5+An4NhQQM//yhjQSsb+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHpJZS5LwbZj29Y524LhWGthh PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ Npl6bGIWBgxZID3hOU7DgF6PjxDfox70eqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DFYUToHx/ixreCu4rW8vrSKTW/95Imjw3g6iiGN6DP JFGN2c1NnwsZTVQM103Kp5hwdyVn1/NUG1873Osm5sOtj27IAtZj+G2bYu9lsaxbcdfk1ucp 2nG13/kGRxcP9uaoRKV/3TpiuLRkCfTXIMJCKb+5vNsmEeUxGEYFFsRT1TTiea9ol6zXZRYM UN8x8Y1hfFsrgrxFIC7BkDm5i7f1vIBZzZOO7EX0BCS0vD52BqYIDUcbBNcVZ8HieZjEFTGy WS1c8PV6S1H6ePOEyvNqOvM9FteKgBOcjRTPnZsoR8tpoC5+dBt1EqnosNLTfbt5uAZDw0c1 NxjQMIWvLwVkcdD/KGy51mvb9mE98WRE1JdCuk6WAuYAuJFiGyNPNfABbvzt68owGOlor6p5 iNspiRmxLpSZaxhbQTUKAn3IF1M2xpiGGaG6WOD4rF7r2j9k5JdVdkIvVmS23uFwu5bIGS0M Sc/SCt65YNJPWvCUEOES9vqUKwXIVzbPY29DJj8N4MWCrAoLVPv1Hw+NCa4gjG2+GBxwP5XB HtuWZv1ZZrsIf88l2TeqiZ0+eJD+x3SMkuJFMinkEz4geTBDJNXIJ9cWGazgikCxPrsiC3e8 spFNtvMzBNaUebkZTLQ/5JVJlcPRUXXz7iv8p0/mjerLlU0FWc/JeXWxL99KYVpk74MzrXD/ 22nW18ew1363CWVJQKPY3FlSbXuQZcg8i5rYX1yZQ6liyo5fIKizKYDbJ9rL7Mpw/NukKxvR P4fdsTeXvkWEmbb+y4QZIXWpZB5cEj5nhqHOieoOWBtf5NpSwHT1MXjew/jqHsHAiat7JNsq Ly8zALLB5EEQl06XsrRbfuuyXK3vGQcx70uDxeZfIELdRy1ooZwKiH3gvsmGO02KE3OlmmAy gKbIRYEvu2R8YU7x8bE2PKfpICzHuogQkcDRzvH7ay7PDXx93a4xdMSS/6BeD3QWT+m+KimY ukJnfjwPOdewQRPuot4Vb1q0bg/953koLoDllZoG3DCblKKDLJ8IybZgZkT5/MVnrIJ6xGrX k+v+8VBPeTbMczoJ1cdOQ45Y7nRzvoTgDTTsaw4LUiSCPWbJ1ZbvZG+5yWxtRE=
- Ironport-hdrordr: A9a23:e3Kzoqtv0A8nUbuRPc1iR84n7skDdtV00zEX/kB9WHVpm6uj5q KTdZUgpHzJYVkqNU3I9ertBEDiexPhHPxOj7X5VI3KNGKNhILBFvAH0WKI+Vzd8kPFmdK1/J 0QFpSXV7bLfD9HZGzBkW+FL+o=
- Ironport-sdr: KkbuIQ0BEQE7k+sqLut0vQPQwha2RgeexUhK8bHnVwWNvS41EEubAbyvTSvWaCWn46psPIDiSB AoOfoIMBZSC5PopY/h5BPYDDsliitSq9m0BI5xQvWQSGGysNZ6JPZyCWTXr60BvMMFQ2v57dNl 72+rGY/DCT/iv+e12fx3bCWVyzzc0+HehFg/zxbDaX0udWzupRPTldSiKGCcXcK7CwK4EdnC14 KKAX9kfcLCmZMeqSateTGuaxv4SBgQK/kl+lxVRB3Oj+TOitCYCzdJGgr/hbmV6zftJYKGdy1R t0hoq6gYaKvHDm4gfqiaqntv
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 22/09/2021 16:01, Roger Pau Monné wrote:
> On Tue, Sep 21, 2021 at 09:18:05AM +0200, Jan Beulich wrote:
>> --- a/xen/include/public/arch-x86/hvm/start_info.h
>> +++ b/xen/include/public/arch-x86/hvm/start_info.h
>> @@ -33,7 +33,7 @@
>> * | magic | Contains the magic value XEN_HVM_START_MAGIC_VALUE
>> * | | ("xEn3" with the 0x80 bit of the "E" set).
>> * 4 +----------------+
>> - * | version | Version of this structure. Current version is 1.
>> New
>> + * | version | Version of this structure. Current version is 2.
>> New
>> * | | versions are guaranteed to be backwards-compatible.
>> * 8 +----------------+
>> * | flags | SIF_xxx flags.
>> @@ -55,7 +55,15 @@
>> * | | if there is no memory map being provided. Only
>> * | | present in version 1 and newer of the structure.
>> * 52 +----------------+
>> - * | reserved | Version 1 and newer only.
>> + * | vga_info.offset| Offset of struct dom0_vga_console_info from base of
> I'm not sure we are supposed to reference external structures like
> that. We took a lot of care to not depend on other headers, and to
> make this as agnostic as possible (IIRC KVM is also capable of using
> the PVH entry point natively, and hence depends on this header).
Absolutely correct. C is not an acceptable ABI description.
Furthermore, dom0_vga_console_info is a bad ABI to start with, as
demonstrated by the multiple problems we've had extending it in the past.
The MB1/2 framebuffer information would be a rather better example to
follow, but we'll surely need to pass the EDID string too (at least in
the case that there aren't EFI runtime services to use).
~Andrew
|
