[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 7/9] x86/PVH: actually show Dom0's stacks from debug key '0'
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Thu, 23 Sep 2021 12:38:52 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=gS7M4mv+sgTTxlL68snpTZ4ltNxdQSv0wHuPxWzPSN8=; b=cDDbQpHo7QGe+vEedOxmMVQxX3dHr+iAaGWrKiYazrujD0gT/bvuW94kBMSNritX2Cyld3AfyEyS2QL5aAnuCGAc06qutg+58zalag04qx3nZKuomY/vHOLkL/SuYgdVDf8AIpHeSovDl7CgdPRomRvUTso/oQKQmH2zyz2OfboQTf6kRmnAvy0vyNI1hTAi3iVh1H4CZCxj16MvfRxvnS8xrAoiOFxSnWGKLJSDowgqmjxQmVQRnT6chcn6KUYPS2op06VrauUpCpJngI48yqDcR8no/GG8hA0k2En/8ukDUBii9b1cXw1x4a671exmJyc25H2qNy38egYehpUZTQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bpliu182gJ1z4Qb2oNMnb6ivSg25nIR7JzMJFxWZ5l5dmiudhVUIk8oj8VgF4iQgyY8oVw7FGoZH7gM0ZehfxKEpQeU07tnSlqY82+elSWn300+hEtdXQFWpnJSN/2jYsmCOA4Aj92duJVrTyvdKIPaAXyQibKBrBTYIRbKjbNRPRL+aL3Eo0W2bbIOxT5W5OE5FqE2maPQwf0vAeYli91Hp1HsYrIXkeOOiofYNQKV6zNV8l7s15I46BSgd0QKdBvLLdVhHhPDKmrKRHF9X7h+Gsgf/Oe2ptqhVwffCgzIfkwWQgpCWMOkY+hV9N9scv6t3zAu8EEA7CiLhcJ/ahQ==
- Authentication-results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Thu, 23 Sep 2021 10:39:06 +0000
- Ironport-data: A9a23:fxB6C61zMUV3iZQTgPbD5Q12kn2cJEfYwER7XKvMYLTBsI5bpzIFn TAbDGqAbv3fNGKhLo9+bou18U8AucSByoBmQVBtpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCan0ZqTNMEn970EoywbVh2+aEvPDia++zk YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhgvZTi /BNiKOKTSwrO5XClesYCUV0DHQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr 6VecW1TKEDY7w616OvTpu1EnMMsIdOtJIoCknph0SvYHbAtRpWrr6DiuIQAhm9p2J8m8fD2Q M8mV2ooMxD6UyJmEFMTM7Bkm+C5mSyqG9FfgA3M/vdmi4TJ9yRu1JD9PdyTfcaFLe1Fk0Ddq m/Y8mDRBhABKMfZ2TeD6mirhOLEgWX8Qo16PL+y++NugVaT7ncOExBQXly+ycRVkWbnBYgZc RZNvHNz8+5iryRHU+URQTWlhlzHmx4hZOBUOO8/0A+Axa+OvyqGUz1soiF6VPQqs8o/RDoP3 1CPns/0CTEHjIB5WU5x5Z/P8mjvY3Z9wXsqIHZeFFpYv4CLTJQb00qXJuuPBpJZmTEc9dvY+ DmMsCF2rLEal8djO06TrA2f3mrESnQkSGcICuTrsoCNslgRiG2NPdXABb3nARBodt3xor6p5 iRspiRmxLpSZaxhbQTUKAn3IJmn5uyeLBrXikN1Ep8q+lyFoiD4J9sLuGkleh04Y67onAMFh meJ4mu9A7cJYBOXgVJfOdrtW6zGM4C6fTgaahwkRoUXOcUgHON21CpveVSRzwjQfLsEy8kC1 WOgWZ/0Vx4yUP0/pBLvHrt1+eJ7l0gWmDKILbimnkvP7FZrTCPMIVvzGADVNb5RAWLtiFi9z uuzwOPQkEgADL2iPHOHmWPRRHhTRUUG6VnNg5U/XsaIIxZ8GXFnDPnUwLg7fJdikbgTneDNl kxRkGcBoLYmrXGYewiMdF55b7bjAcR2oX4hZHR+Nle0wXkzJ42o6f5HJZcweLAm8s1lzOJ1E KZZK5nRXKwXR2SV4SkZYLn8sJdmKEahizWRMnf3ezM4ZZNhGVDEo4e2Ygv1+SASJSOrrs9i8 aa43wbWTMNbFQRvBcrbcty1yFa1sSRPke5+RRKQcNJSZF/t4M5hLCmo1q07JMQFKBPiwDqG1 lnJXUdE9LeV+4JsqYvHn6GJqYutAtBSJEsCEjmJ96uyOAnb4nGnnd1KXtGXcG2PT2jz4qijO 7lYlqmuLP0dkV9WmINgCLI3n7km7t7iqrIGnARpGHLHMwaiBr96eyTU2MBOsutGx6NDuBvwU UWKo4EINbKMMcLjMVgQOAt6MbjTiaBKwmHfvaYvPUH3xC5r577WA0xdMi6FhDFZMLYoYpgux v0suZJO5gGy4vbw3g1qUsyAG7ywE0E9
- Ironport-hdrordr: A9a23:Hv9lWaP7idwCE8BcT1D155DYdb4zR+YMi2TDiHofdfUFSKClfp 6V8cjztSWUtN4QMEtQ/uxoHJPwO080kqQFnLX5XI3SJzUO3VHHEGgM1/qB/9SNIVyaygcZ79 YdT0EcMqyAMbEZt7eC3ODQKb9Jq7PmgcPY9ds2jU0dNT2CA5sQkTuRYTzrdHGeKjM2YabQQ/ Gnl7V6TnebCDkqR/X+IkNAc/nIptXNmp6jSRkaByQ/4A3LqT+z8rb1HzWRwx9bClp0sPgf2F mAtza8yrSosvm9xBOZ/2jP765OkN+k7tdYHsSDhuUcNz2poAe1Y4ZKXaGEoVkO0a2SwWdvtO OJjwYrPsx15X+UVmapoSH10w2l6zoq42+K8y7RvVLT5ejCAB4qActIgoxUNjHD7VA7gd162K VXm0qEqpt+F3r77WTAzumNcysvulu/oHIkn+JWpWdYS5EiZLhYqpFa1F9JEa0HADnx5OkcYa hT5fnnlbRrmG6hHjXkVjEF+q3pYp1zJGbJfqE6gL3X79AM90oJiHfxx6Qk7z49HdwGOt95D0 mtCNUdqFh0dL5lUUtKPpZ2fSKGMB2/ffvyChPmHb3GLtBNB5ufke+83F0KjNvaD6DgiqFCwa j8bA==
- Ironport-sdr: 5gNW6APMgNzWFtZUud4PvTyln0NUrDmHWUYUHSQXLhH6qpe3LuuqF50jnDNWjLRWIWK0pn9xLr e7MxI0KoquJMaYQKRK3JLzpZI9A3D5u8JskeqVHYWAqtGfG7ow/LvCL4QcQPhCqMt6P/5roYYc xDflBcz4YuQdkTjIVdt6/sQjBeKzrs9JneL2O/KT01eOYlV2jMizSWShfmRx2lM6aT0ltB0kMl B7lTJawG49/q8eUreqFT9v6CRvMACn3JVJ+/RnPtwa7+AGg3N0zBZ8eus5bnriIijnRhhze1iO D6ryswT7EpXSfo8uJJ1/VO+z
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Sep 23, 2021 at 12:31:14PM +0200, Roger Pau Monné wrote:
> On Tue, Sep 21, 2021 at 09:20:00AM +0200, Jan Beulich wrote:
> > - /* Prevent interleaving of output. */
> > - flags = console_lock_recursive_irqsave();
> > + /*
> > + * Prevent interleaving of output if possible. For HVM we can't do so,
> > as
> > + * the necessary P2M lookups involve locking, which has to occur with
> > IRQs
> > + * enabled.
> > + */
> > + if ( !is_hvm_vcpu(v) )
> > + flags = console_lock_recursive_irqsave();
> >
> > vcpu_show_registers(v);
> > - if ( guest_kernel_mode(v, &v->arch.user_regs) )
> > + if ( is_hvm_vcpu(v) )
> > + show_hvm_stack(v, &v->arch.user_regs);
>
> Would it make sense to unlock in show_hvm_stack, and thus keep the
> printing of vcpu_show_registers locked even when in HVM context?
To clarify, the unlock should be limited around the call to
show_hvm_stack, not to be performed inside of the function itself
(since we would have to pass flags around then).
Thanks, Roger.
|
