[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 1/2] xen-pciback: prepare for the split for stub and PV


  • To: Oleksandr Andrushchenko <andr2000@xxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 23 Sep 2021 13:10:50 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=5n8E4qDNOXyPRZiTn4zsnzmSBAjyQQDHUXlXehU+4/E=; b=b0ANod3y0yT1cVjQcXawCokCazyeuvRwJY69aMvkSjugSjREOlVJIgabXtWI9f9cxEn4RNlI4oP5pqQq/XG3rixqNH4YVE8zZuzISGA5KrSJcBydUiIBMuwW1PIkYZ3cUOYdmXDIWvuHA55lee1vOMdlvwedXEN7khHoZnUq24i5I2lkfNSvX5aFq1Kg6uNbxPkAblFLi1Qfj16iK/vWDYDDPcxY2kFpHhLGxhEiTBl93wk8Si6J2OjGqQURlqHquz73gdDGOb/nipucoC81G/HHuGEpMOaRU0w5sPjN4FM6nejBbF0KsKMQyUCV9f18BRfR6zkvkMAzbRn75oYpGA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Aj2dgfk1cZqcAYpsJ3ql+31AmQTVIY40+Kt4ht+l1WKq54rZKOu6uGXPHZgXuiQw7WG+3G9kitx6FGRoo1Th5SbdEASxOAXgi4iVykdLqPuA+IlE9GV00+P4gSbQCNjdmtcIFB3b2I1mZzUx1NroamMvLyMvMJuV3nEL8MtMhIUGM1Y3vR9NXP1ScnVmEjGwj1AeHM9CYzWUPxb1kg7M1JQ0AJNbt+L1A+0j194QfBq8KC6Y0LH3BDhsMruCLlhNJ3nuFMJo54abtHv/ZIwXqMaAcO0sEWDZ1b1DonfUmIBzIwzjGJ95XeFBIXaKJYs5g//4hbCqZHgbHewdmNoUMA==
  • Authentication-results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=suse.com;
  • Cc: boris.ostrovsky@xxxxxxxxxx, jgross@xxxxxxxx, julien@xxxxxxx, sstabellini@xxxxxxxxxx, Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
  • Delivery-date: Thu, 23 Sep 2021 11:11:01 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 23.09.2021 11:53, Oleksandr Andrushchenko wrote:
> --- a/drivers/xen/Kconfig
> +++ b/drivers/xen/Kconfig
> @@ -180,10 +180,34 @@ config SWIOTLB_XEN
>       select DMA_OPS
>       select SWIOTLB
>  
> +config XEN_PCI_STUB
> +     bool
> +
> +config XEN_PCIDEV_STUB
> +     tristate "Xen PCI-device stub driver"
> +     depends on PCI && !X86 && XEN
> +     depends on XEN_BACKEND
> +     select XEN_PCI_STUB
> +     default m
> +     help
> +       The PCI device stub driver provides limited version of the PCI
> +       device backend driver without para-virtualized support for guests.
> +       If you select this to be a module, you will need to make sure no
> +       other driver has bound to the device(s) you want to make visible to
> +       other guests.
> +
> +       The "hide" parameter (only applicable if backend driver is compiled
> +       into the kernel) allows you to bind the PCI devices to this module
> +       from the default device drivers. The argument is the list of PCI BDFs:
> +       xen-pciback.hide=(03:00.0)(04:00.0)
> +
> +       If in doubt, say m.
> +
>  config XEN_PCIDEV_BACKEND
>       tristate "Xen PCI-device backend driver"
>       depends on PCI && X86 && XEN
>       depends on XEN_BACKEND
> +     select XEN_PCI_STUB

Does kconfig not at least warn about this? The selected item has a
"depends on !X88" conflicting with the "depends on X86" here.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.