[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 02/17] xen/pci: solve compilation error on ARM with HAS_PCI enabled
- To: Julien Grall <julien.grall.oss@xxxxxxxxx>
- From: Rahul Singh <Rahul.Singh@xxxxxxx>
- Date: Thu, 23 Sep 2021 11:14:50 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=uGOPPHVn3iO3ThBFgg3V+W+0iB/6oRHnxU04VoSJulc=; b=Z0QZuQrdro6eqflNnZ9R1+lHeNgL4BPIop4idpQrlz97Dm30PIGLqEkx+ytD8nxRJg0xDegws55ah/sgSKt9Ne/d3d7SV8M75oy3udOOoj0dWixgSlftn9ZqK2eGknE0MH9C7Luidymv1dEkaoZH5oXBXzj5c21qPO+8qtajOf/fVd+GXn78g5YQpuzWNZO3x+0bzSO5KyxXgUTKVfqFxGgGd6a/fNaNg7Ez+2ay/NfluWlSYxiJqtYCMZgn1JCl4NtIh9M6a+DMjH2laAxNn/nKOosY65CDjHJy4Lj3cAvHpmbgK3SP/oaFdgVvSqVOhwI+HiyHdLZxLOjQM/gEIg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wx6FyFJ2GzTZbL277U9TUdMqXHllcVWA4g/VsrQuyynFd3s0ZWycieWIL2Y5ivlkGP25mnDTls/Qk3xW0802Oe5U17gbgU07P5GKz2GpqhQfdq4tF6kd3i5dXhHHjR5pJSwU6fv3h//YvGXUx+HNeGtg61t56JQgygaASzhZgDTr+nii+C/hec5k10JRoDoLVGI+t4qcroFmiMkixwb6SLIYv+RoPRsvd5yz9sW9Tz9OJ66OYz/g8fq/PmMCB37/JdUk04MEywS762BSUEijCZJusFnKyWcEJAhdJ2nD99CKz25d0dt+kUc94c1fgVyeA6/vDfQe6B3ybbUvKHnRrQ==
- Authentication-results-original: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=arm.com;
- Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Andre Przywara <Andre.Przywara@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Thu, 23 Sep 2021 11:15:10 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHXr6YM7M3wnWXhpk+HlxEaE7sJMauw4CUAgACZAIA=
- Thread-topic: [PATCH v2 02/17] xen/pci: solve compilation error on ARM with HAS_PCI enabled
Hi Julien
> On 23 Sep 2021, at 3:07 am, Julien Grall <julien.grall.oss@xxxxxxxxx> wrote:
>
> Hi,
>
> On Wed, 22 Sep 2021, 16:36 Rahul Singh, <rahul.singh@xxxxxxx> wrote:
> Compilation error is observed when HAS_PCI is enabled for ARM
> architecture.
>
> In general, when I read "compilation error" I interpret as a user can trigger
> it in the current staging.
>
> However, without the full series applied, HAS_PCI cannot be selected on Arm.
>
> So I think the message is a bit misleading because this is more implementing
> stubs to enable a feature rather than fixing compilation errors (AFAICT all
> of them are not fixed here).
>
> How about the following commit message:
>
> xen/arm: pci: Add stubs to allow selecting HAS_PCI
>
> In a follow-up we will enable PCI support in Xen on Arm (i.e select HAS_PCI).
>
> The generic code expects the arch to implement a few functions:
>
> <List the functions>
>
> Note that this is not yet sufficient to enable HAS_PCI and will be addressed
> in follow-ups.
>
Ok. I will modify the commit message in next version.
Regards,
Rahul
|
