[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 13/17] xen:arm: Implement pci access functions
- To: Julien Grall <julien@xxxxxxx>
- From: Rahul Singh <Rahul.Singh@xxxxxxx>
- Date: Thu, 23 Sep 2021 15:17:47 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=G36TS6GIEuBLd1hXsVLcS/2Ztquu31Kr/R6Fo0WYLN8=; b=P835xLS+TMtFxcsb+E6YrN0lyBz7PERrSBAczzeIuB8nAEniPkEiz+0zZmH1xGVWsoEp+iZ7i1CMZHDa7Y34Ik7RZFdFxQeUj64T5P/uQQAyLHZTeCr8dWe2MOY/CeK0ywDhEOI4H2zEmC+oBI+g1W02CzN70VuVVS83yChDyrvvWZjvOiGyEbWhnYt8vLNO6P+plWp1Ge7wckVa6rlJMIB6UxSe/d1HKsjxLFdElUq5BUocNOt5jFRfqI6r5JFWaTf5UWmq9ZhxTGlOGXoiRFhMEuep4iaBShxN6FFG1KFS1txV/CqQgDK2DcQThRP+kUuXflFDoZ0cORcmvBiJuQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZoLgDEGDWuphW87KTynSJRuKMyyWtg2xqBVh/0h2jjt8187zgP0jLWoMnVFCVDxA/gm+FUVgVyfq4d1oVH+LXWPfBAdW3LBbiqiAYowHdPMvRpEyyqF59+TbIUQwXvq+Sp2Z+lyO3qwMsUygRchKeaJPS5sjknj93SJd0izAsMutbwtsT9LcgTF786hHC9Rmi14uv0QIN8CSUQf5wCb0iiZbPDpx5whELknHSOMOaepBe0VGSHw0DRMVGD9Kot1vNwj3VkfGlkkyW1VCLTRAAwAg+HjP23kgpKe1VQz/zqQi3kPBjPLIm8t0aW4FWC8nf+YKabh20WFV8RIO4sKkVw==
- Authentication-results-original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Andre Przywara <Andre.Przywara@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Thu, 23 Sep 2021 15:18:16 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHXr6aktO5EpOLLjku5HahQRSHFEauw5LyAgABsh4CAAGvCAA==
- Thread-topic: [PATCH v2 13/17] xen:arm: Implement pci access functions
Hi Julien,
> On 23 Sep 2021, at 9:52 am, Julien Grall <julien@xxxxxxx> wrote:
>
> Hi,
>
> On 23/09/2021 07:23, Stefano Stabellini wrote:
>>> diff --git a/xen/include/asm-arm/pci.h b/xen/include/asm-arm/pci.h
>>> index 4b32c7088a..5406daecda 100644
>>> --- a/xen/include/asm-arm/pci.h
>>> +++ b/xen/include/asm-arm/pci.h
>>> @@ -18,6 +18,7 @@
>>> #ifdef CONFIG_HAS_PCI
>>> #define pci_to_dev(pcidev) (&(pcidev)->arch.dev)
>>> +#define PRI_pci "%04x:%02x:%02x.%u"
>> This is added in this patch but it is unused here
>
> To add on this, this is technically not arch specific. So if this is
> necessary in a follow-up patch, then the definition should be moved to a
> generic header.
I introduces this to print SDBF but I think it is better to use %pp to print
SBDF. I will remove this in next version.
Regards,
Rahul
> Cheers,
>
> --
> Julien Grall
|
