Re: [PATCH 10/37] xen/x86: use helpers to access/update mem_hotplug

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

+x86 maintainers


On Thu, 23 Sep 2021, Wei Chen wrote:
> We want to abstract code from acpi_numa_memory_affinity_init.
> But mem_hotplug is coupled with x86. In this patch, we use
> helpers to repace mem_hotplug direct accessing. This will
             ^ replace

> allow most code can be common.
                  ^ to be

I think this patch could be merged with the previous patch


> Signed-off-by: Wei Chen <wei.chen@xxxxxxx>
> ---
>  xen/arch/x86/srat.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/xen/arch/x86/srat.c b/xen/arch/x86/srat.c
> index 2f08fa4660..3334ede7a5 100644
> --- a/xen/arch/x86/srat.c
> +++ b/xen/arch/x86/srat.c
> @@ -391,8 +391,8 @@ acpi_numa_memory_affinity_init(const struct 
> acpi_srat_mem_affinity *ma)
>       memblk_nodeid[num_node_memblks] = node;
>       if (ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE) {
>               __set_bit(num_node_memblks, memblk_hotplug);
> -             if (end > mem_hotplug)
> -                     mem_hotplug = end;
> +             if (end > mem_hotplug_boundary())
> +                     mem_hotplug_update_boundary(end);
>       }
>       num_node_memblks++;
>  }
> -- 
> 2.25.1
>