[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 24/37] xen/arm: implement two arch helpers to get memory map info
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: Wei Chen <Wei.Chen@xxxxxxx>
- Date: Fri, 24 Sep 2021 04:42:48 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=00S8jcIrVFBN1uvTM84xghtlh7RjwXB42v2XnvIPF7c=; b=F7QI23EDhSjlKUSspSI3qJGVxzzbJWSITbXr5Pmjr3B6aurbVGCwqQSvB9/MrZc+r8kjkPeYIppO0ga/jJWDRoPD6PuZjPQyWxAfOIKoNfDZ0zN+Nx1UhozH4pxh/Y8sBVZ74aX/V1Mm4j3ps8CBnQUr86qQAY8VEdX2ku7bpWChYVBg2vy/PNOSj7oacaMb7wBVhsCpy37NkBtKKQK9u/PXUNSB9rQwCPY80bZNPLjGvPbE9wAwxKkjLV0Yd2NXLNsycAIjRd/yxptHTBBj1CMqCuEUKT5+FQd84uHUe3HS3ZT0bEjSvXkRVeRa2KgRrQ+EoKFmceP6SDEcKF1vag==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iAjnapZeGk/eal9QCSPtSol+JN/cpq+xf4emWUKkSJs0eyhjkFG7er8EOkGxQqklQ3/YoURdCKVq4lOPVAANatOL7et9Qnz2Jeunj43T2W3OD4RPo9UID2ejg4H53Uwkq1eHLkiF1v/dd0VY8UzppI/DRQxSCyUgpyaFrsScHHk8aXSzOtCREhgFJg6H75h1mdYnhOU8vx1e2/0/iuCMuKb8RQZ6yfWd7P2UuVTk5MT5PTZWIlUYAcunpoF0OapOW5LoJZbpJqLX0+4K2GcIhom8Uq4CB8oIbIPYa7dmybftRuT5svsH0j55eD3kKDpJV4qn/SPl1tNaD73d0z/lig==
- Authentication-results-original: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Delivery-date: Fri, 24 Sep 2021 04:43:06 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHXsHM4IX7m67p9UE2HNfweaKhzBauycKqAgAArlfA=
- Thread-topic: [PATCH 24/37] xen/arm: implement two arch helpers to get memory map info
> -----Original Message-----
> From: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> Sent: 2021年9月24日 10:06
> To: Wei Chen <Wei.Chen@xxxxxxx>
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx; sstabellini@xxxxxxxxxx; julien@xxxxxxx;
> Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
> Subject: Re: [PATCH 24/37] xen/arm: implement two arch helpers to get
> memory map info
>
> On Thu, 23 Sep 2021, Wei Chen wrote:
> > These two helpers are architecture APIs that are required by
> > nodes_cover_memory.
> >
> > Signed-off-by: Wei Chen <wei.chen@xxxxxxx>
> > ---
> > xen/arch/arm/numa.c | 14 ++++++++++++++
> > 1 file changed, 14 insertions(+)
> >
> > diff --git a/xen/arch/arm/numa.c b/xen/arch/arm/numa.c
> > index 3f08870d69..3755b01ef4 100644
> > --- a/xen/arch/arm/numa.c
> > +++ b/xen/arch/arm/numa.c
> > @@ -67,3 +67,17 @@ uint8_t __node_distance(nodeid_t from, nodeid_t to)
> > return node_distance_map[from][to];
> > }
> > EXPORT_SYMBOL(__node_distance);
> > +
> > +uint32_t __init arch_meminfo_get_nr_bank(void)
> > +{
> > + return bootinfo.mem.nr_banks;
> > +}
> > +
> > +int __init arch_meminfo_get_ram_bank_range(uint32_t bank,
> > + paddr_t *start, paddr_t *end)
> > +{
> > + *start = bootinfo.mem.bank[bank].start;
> > + *end = bootinfo.mem.bank[bank].start + bootinfo.mem.bank[bank].size;
> > +
> > + return 0;
> > +}
>
> The rest of the file is indented using spaces, while this patch is using
> tabs.
>
> Also, given the implementation, it looks like
> arch_meminfo_get_ram_bank_range should either return void or bool.
I will fix them in next version.
|
