[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 20/37] xen: introduce CONFIG_EFI to stub API for non-EFI architecture

  • To: Wei Chen <Wei.Chen@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Fri, 24 Sep 2021 09:58:32 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Ndh2/WkbZIVBkTWBYx/Nsdae6UJSf66kgIISO2ix5KQ=; b=H8Ez8OyoDl3NAleGMBeux8Nd8Yuc008erM5Yqu8ST9mru/6SbAGmPGjlFqI6S0kp4ZMPdUT3qaf2/KGcUYQxSYr/qFVedzsPv63kr8yEuY3grQTE45TcM054B9005RZ46IixfyO0Uloid7MdxQ/2bo37HPjbe3f9WLIobREGea4NYCbxVEVsUhYJkZIBEm7PfRrlJEO+s2M2kSD15wIRIctUzq5CEcvbnpNbXopoZQaUFtqYabgP1NgU1F6y4DLrTVlUfXTIE2tzcCC1doY8eZEc37MljoIUDdKzwTAp/EsjJPfH73A7m75cWVXxa2FtGkHKHIS1uq4Ef57qODSIuw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZtKmmCUOaFx60qajl4bcBdj9HK0zWATu/OGsTmF0kt0RVZxKCThCF8uSEwliTgyiTP+dbwxZIXdlDV8Y2za9oGZlLEpLPvciV2ajw9ACWkLoZkecaVrKGbQJ7PnoFoBWfDMQtnGypYi2kiJLNK2mR8PTsgLHTMcdUynPmuWhbTKx3ZjqEVTohcC4znVBeTb/Ns0vs+cwn6jX3kni8OD+7NE/FxNEH8sr0J1tQI54/Ue43uTc1ipj2u0vDXEyCYURd/fsFUroI5YWQcVHyGH934v1osLnjAJ8gtFoFik75VyCI1A4YcPKC3oA2jiuooqWI6dg3dyOSEJnq+8SoheZxQ==
  • Authentication-results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=suse.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • Delivery-date: Fri, 24 Sep 2021 07:58:40 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 24.09.2021 06:34, Wei Chen wrote:
>> From: Stefano Stabellini <sstabellini@xxxxxxxxxx>
>> Sent: 2021年9月24日 9:15
>> On Thu, 23 Sep 2021, Wei Chen wrote:
>>> --- a/xen/common/Kconfig
>>> +++ b/xen/common/Kconfig
>>> @@ -11,6 +11,16 @@ config COMPAT
>>>  config CORE_PARKING
>>>     bool
>>> +config EFI
>>> +   bool
>> Without the title the option is not user-selectable (or de-selectable).
>> So the help message below can never be seen.
>> Either add a title, e.g.:
>> bool "EFI support"
>> Or fully make the option a silent option by removing the help text.
> OK, in current Xen code, EFI is unconditionally compiled. Before
> we change related code, I prefer to remove the help text.

But that's not true: At least on x86 EFI gets compiled depending on
tool chain capabilities. Ultimately we may indeed want a user
selectable option here, but until then I'm afraid having this option
at all may be misleading on x86.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.