[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2.1 15/12] xen/trace: Drop old trace macros
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 24 Sep 2021 15:31:45 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=wcPWF3Ey9MNZejsP0eOYbzs9p+6nxvxxT3zaAA/DYik=; b=M9fQjPLdYYlnndjB/B+jbzRshzB3jngw4YQsQFHKB/BgIGCmTxVrDxmSs9aH3xaR2x/NaDmjMlIlt8QnjZm65CKzqsg+Vk8+qp6wvYDPeS37W9M085ee1iMQRPmkX5lOdJ0y0ME5k2EbgOUT4TkEswogPwHgu7iH1AtLIqkLtZSnxuYMm5u/wbg9s8iSz+6WhTLfwNmR2jIFefG+AgD5VW45iUAS/ni26buW6rti5gkkrAkJQdLA2ysE2r5ZDTR2bQhMwgu3lz3o3EQFL1ibod1IsRyGBT/gUAY0+B0B1StkFF5RmMpf9TdGfhxlHwvstgxIAGYyUmGwDNZHRNDuUA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dRBh+LHNf/otLKI/ih3o9SnjwsMXnAKw7lAHVi6s4ecdXF54myEp1zJF8qHJpMLOFjMxwKGwsYxlSSGtd9DLCMkAvpwPd4t9U3wvi1NA7mBU1e2DK3ehVWvAW8tmbtePXhBZ1UcZzwORsFrTe/BY4pbJK9FRTm6JGGpmllfl3ajy1ISDS3iXHs9CwnedpToJznP5VjL6+FXGON8sRINOwNfP5FKvnNjylfco0ZO3Hj20ENcrw0HjIhHgOugcRVzs9cH1GJC/Oe1oDH0wuPJraiPPz3EoZoFTlrKFFZlYUgtm17Rq77+745gRl4uYs9aOStRoQrWV8SuubAiOIYZANA==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 24 Sep 2021 13:32:01 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 20.09.2021 21:33, Andrew Cooper wrote:
> With all users updated to the new API, drop the old API. This includes all of
> asm/hvm/trace.h, which allows us to drop some includes.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
albeit I'd like to note that ...
> --- a/xen/include/asm-x86/hvm/trace.h
> +++ /dev/null
> @@ -1,114 +0,0 @@
> -#ifndef __ASM_X86_HVM_TRACE_H__
> -#define __ASM_X86_HVM_TRACE_H__
> -
> -#include <xen/trace.h>
> -
> -#define DEFAULT_HVM_TRACE_ON 1
> -#define DEFAULT_HVM_TRACE_OFF 0
> -
> -#define DEFAULT_HVM_VMSWITCH DEFAULT_HVM_TRACE_ON
> -#define DEFAULT_HVM_PF DEFAULT_HVM_TRACE_ON
> -#define DEFAULT_HVM_INJECT DEFAULT_HVM_TRACE_ON
> -#define DEFAULT_HVM_IO DEFAULT_HVM_TRACE_ON
> -#define DEFAULT_HVM_REGACCESS DEFAULT_HVM_TRACE_ON
> -#define DEFAULT_HVM_MISC DEFAULT_HVM_TRACE_ON
> -#define DEFAULT_HVM_INTR DEFAULT_HVM_TRACE_ON
... least the part up to here as potentially useful to limit trace
output. Afaics there's no replacement in the new model, as you
invoke the base tracing macros now directly.
Jan
|
