[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 01/12] xen/trace: Don't over-read trace objects

  • To: Jan Beulich <JBeulich@xxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>
  • From: Dario Faggioli <dfaggioli@xxxxxxxx>
  • Date: Fri, 24 Sep 2021 14:35:37 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=gwEnhWffpKikd6V7ogwpbryzoiQJzAI8CfaIrrWolWU=; b=CEzyCVPsV1263893sqW8UUAznLGHTk819LJAXLM2sO6OwzdI8Lcdi+bOs0vCqYwH5Rk3IPKL+1WFS9D9rQyJJ/BV/pbP4NgNh1d8w5t2pOzPVajgZNfX52pIthKSxp/FItKhPsCa10L280af/oAOzCgsoS04U1jPHStDJUd7scrAjca/9y0l+vy/Ds8HQQrjYIRqViBHA8IUBH9plajixRi/WRseBy2uXjbeArj9bY1eIZ8cTomWXvPn0FiBpOfatZWlCUKH7JPd2YrW4wPaU6TI1meY+Bvt4tTW1X6V4NVQ2GXBSKfuc4OZTeqpGtuA7qctPvY9wze8E3ZisjLaXQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hCNqIGr6p6gL9osUJl95idQYvXMFMsb8M6mMnNPfNgWfNQIhOLPI1jglOREMximPWDi8dvseuWsLp11i8/fGg/8v+PwIgVq8piTw9etfoYl/XvDAoya+VtiUOm/Q8CzRpi4mb3rR/y0QZKqv5NwbMJCs/4IHAHpdomotuGU24mJmTtrBc/m19Rdueyu7MPs5ZzpRupLfrzOsbTRCG3PHInzXjNgcolYLPGH8buS+AqvPVDg+XARz78KbNs2m3Z9qFSm2iyJ0jvsHVKJ5tqmF5OU1/7uTOPEbnaQhWKibR/50v6sDX2xcZF+mLjVq0zn8q9aTjfRBVz4xtXPExLqUcA==
  • Authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=suse.com;
  • Cc: "julien@xxxxxxx" <julien@xxxxxxx>, "George.Dunlap@xxxxxxxxxxxxx" <George.Dunlap@xxxxxxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "iwj@xxxxxxxxxxxxxx" <iwj@xxxxxxxxxxxxxx>, "wl@xxxxxxx" <wl@xxxxxxx>, "mengxu@xxxxxxxxxxxxx" <mengxu@xxxxxxxxxxxxx>
  • Delivery-date: Fri, 24 Sep 2021 14:36:01 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHXrkSLbMGUvlBXkkK2FQ1vuFXyFauuDj2AgAC3ywCAANyhAIAAY+SAgAM/yQA=
  • Thread-topic: [PATCH v2 01/12] xen/trace: Don't over-read trace objects

On Wed, 2021-09-22 at 13:58 +0100, Andrew Cooper wrote:
> On 22/09/2021 08:01, Jan Beulich wrote:
> > 
> > Agreed. Whether the truncation is an issue in practice is
> > questionable,
> > as I wouldn't expect budget to be consumed in multiple-second
> > individual
> > steps. But I didn't check whether this scheduler might allow a vCPU
> > to
> > run for this long all in one go.
> I expect it's marginal too.  
It is indeed.

> Honestly, its not a bug I care to fix right
> about now.  I could leave a /* TODO: truncation? */ in place so
> whomever
> encounters weird behaviour from this trace record has a bit more help
> of
> where to look?
Sure, that's fine for me.

Thanks and Regards
Dario Faggioli, Ph.D
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)

Attachment: signature.asc
Description: This is a digitally signed message part



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.