[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 09/12] xen/trace: Minor code cleanup
- To: Jan Beulich <JBeulich@xxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>
- From: Dario Faggioli <dfaggioli@xxxxxxxx>
- Date: Fri, 24 Sep 2021 15:16:08 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=RWqq9mAcIYwMkvDTrO88ltRzUibHN1PcXj89F8puzRM=; b=mrSRr78jtI/LLWJQhYqRJP/3+xDiteCsvOb5K51qg2eLmmNyNbZSB0zgzp8jSBUQ0CXB/Nmk/FrSCjibIYV9oaviYc+qNCoyhOi7In3LjnEKxwLXpsqlLVeGG2Vg9TixjKQghMBUvfS54tQoQBEeIXy8wyMgcO9CCRTZmJsG3YdI4ve7LnpilAznSVEVuAkmPfXFTgjMVybNwegSTqdKeSA9sBT+85XbTOm9xFWRTXnR+k6xCNlIId6dkZ7yBJpfwctqFc0j0IqVvhu4CqEp5ehB05VOKmT3LbFZk4gC5BjaZRJRIvgpDfgzScQ7WI8VLkdqjU04nTp/kvlBYvjAiw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TNSZskXnU5WZu7dUDps60oM1rpbeo0ubPPkqu3+D7NMYQYAekP9qZW3xSNvAUl1gswXKGjYlnM3SyfzJLe9cKlw2E2qhfZ06H5uORXVqFFvpaQPJ9Ke2SeV0Hrvu68ks9YK3kqd1fdT84HpUjRQY1zbfHz09m1AgvNc1i7xNukWWryT6EhQhGURLCjl0NTNJQhzm4nBrMCGUANm8zNSb0QY/bihtRhGukbElIVup7wAlgJbUwkZhF3PQpY9QYOms/EAeqpFunEoTAHaEKE0MEEDIduqwV6vqhzbvz0ziUcNWWrII0hSOQVexIPPZ4u8fl73zq4AoSj0W+2JRthpfQA==
- Authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=suse.com;
- Cc: "julien@xxxxxxx" <julien@xxxxxxx>, "George.Dunlap@xxxxxxxxxxxxx" <George.Dunlap@xxxxxxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "iwj@xxxxxxxxxxxxxx" <iwj@xxxxxxxxxxxxxx>, "wl@xxxxxxx" <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 24 Sep 2021 15:16:22 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHXrkSNUXB03Bf2kEahk+mMoXgWnquuVDIAgAT9eAA=
- Thread-topic: [PATCH v2 09/12] xen/trace: Minor code cleanup
On Tue, 2021-09-21 at 13:03 +0200, Jan Beulich wrote:
> On 20.09.2021 19:25, Andrew Cooper wrote:
> >
> > Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>
> Like for v1: Largely
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
>
Reviewed-by: Dario Faggioli <dfaggioli@xxxxxxxx>
> One remark:
>
> > @@ -717,9 +713,6 @@ void __trace_var(u32 event, bool_t cycles,
> > unsigned int extra,
> > if ( !cpumask_test_cpu(smp_processor_id(), &tb_cpu_mask) )
> > return;
> >
> > - /* Read tb_init_done /before/ t_bufs. */
> > - smp_rmb();
> > -
> > spin_lock_irqsave(&this_cpu(t_lock), flags);
> >
> > buf = this_cpu(t_bufs);
>
> I wonder whether the comment wouldn't be helpful to move down here,
> in of course a slightly edited form (going from /before/ to /after/).
>
FWIW, I agree with this (but the R-o-b: stands no matter whether it's
done or not).
Regards
--
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)
Attachment:
signature.asc
Description: This is a digitally signed message part
|
