[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2.1 14/12] xen: Switch to new TRACE() API

  • To: "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Dario Faggioli <dfaggioli@xxxxxxxx>
  • Date: Fri, 24 Sep 2021 15:30:05 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=QIrnMBnIvxtySEdOc2GunU4qTCLynbDICb1WQvw3Inw=; b=jyZwAr0K320Y15CKXC3X/Z/QOdTAHLOZCYSvNQnArZ4H1U1bndurwMy62wQRMAbkEXUHggrxWB8WuLptdAH7Qzg2OkDQao6Du61YPTygpZNHsskhlBLf+E6cdDpseD5LtLUXW1nqg+sB6fhybWihJEaRBHiLGgT9v7Y44KJnOHQcHfCcmzcCQLuxrjBZTKfhilYpz4qqySPuPQk3lrQLQS64S543cmgFKcNfEVlGDi83uJuMDN6HXMwQW94NculsUeimeBuTiG6lCpN2apIPd0CKb/yfB6jF54vEPcIue7ecxWccSmCpEWMVGmJWCG9adHfPuA0HeKcdo1sj1NX+QQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n+IcIT7iTZt48Ho8ak/k/1m7fwe/eKK6iUlfFpw2Z1hf6Pi99ELh6kR3rASGweFYsjQ25vuakeQYVxgMNP2sBoJhF+e8Iz8z0pFVAADaz/d9h5VInVKC8bzEpF4SJOpVgOfGUidjxKrPF5AO70x7Iu4JEs+gTNRl14UBWrn3y9qFVyvfgvX+Y1RkDU1Q18NwDQw/5c8i2AcrQZ1yZzT63coZyXO1kNnEBnTPDMv3sIoHiybz3woND/IyPbez9eSKDqTtj2wwI9hUnopZzrAapDhpAs62D3rwFI3JaDf4z0/XZib4lb5B2BbsvN+wyGGpf8poKh/uarSUJakL5wEMhg==
  • Authentication-results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
  • Cc: "julien@xxxxxxx" <julien@xxxxxxx>, "George.Dunlap@xxxxxxxxxxxxx" <George.Dunlap@xxxxxxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, "iwj@xxxxxxxxxxxxxx" <iwj@xxxxxxxxxxxxxx>, "wl@xxxxxxx" <wl@xxxxxxx>
  • Delivery-date: Fri, 24 Sep 2021 15:30:12 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHXsVkMcY6jWQHaHkuxnpRFfdaE/Q==
  • Thread-topic: [PATCH v2.1 14/12] xen: Switch to new TRACE() API

On Mon, 2021-09-20 at 20:32 +0100, Andrew Cooper wrote:
> (Almost) no functional change.
> irq_move_cleanup_interrupt() changes two smp_processor_id() calls to
> the 'me'
> local variable which manifests as a minor code improvement.  All
> other
> differences in the compiled binary are to do with line numbers
> changing.
> Some conversion notes:
>  * HVMTRACE_LONG_[234]D() and TRACE_2_LONG_[234]D() were latently
> buggy.  They
>    blindly discard extra parameters, but luckily no users are
> impacted.  They
>    are also obfuscated wrappers, depending on exactly one or two
> parameters
>    being TRC_PAR_LONG() to compile successfully.
>  * HVMTRACE_LONG_1D() behaves unlike its named companions, and takes
> exactly
>    one 64bit parameter which it splits manually.  It's one user,
>    vmx_cr_access()'s LMSW path, is gets adjusted to use
>  * TRACE_?D() and TRACE_2_LONG_*() change to TRACE_TIME() as cycles
> is always.
Was this supposed to be "as cycles is always 1", or something like
that? (But maybe it's fine and it is me. I'm no native speaker after

In any case...

>  * HVMTRACE_ND() is opencoded for VMENTRY/VMEXIT records to include
> cycles.
>    These are converted to TRACE_TIME(), with the old modifier
> parameter
>    expressed as an OR at the callsite.  One callsite,
> svm_vmenter_helper() had
>    a nested tb_init_done check, which is dropped.  (The optimiser
> also spotted
>    this, which is why it doesn't manifest as a binary difference.)
>  * All HVMTRACE_?D() change to TRACE() as cycles is explicitly
> skipped.
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Reviewed-by: Dario Faggioli <dfaggioli@xxxxxxxx>

Dario Faggioli, Ph.D
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)

Attachment: signature.asc
Description: This is a digitally signed message part



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.