[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 02/12] xen/memory: Remove tail padding from TRC_MEM_* records

  • To: "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Dario Faggioli <dfaggioli@xxxxxxxx>
  • Date: Fri, 24 Sep 2021 16:50:15 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=9A0+pnQRcAewGwpyyb5SKYkn/HCvTCcn0tztU1NU3PA=; b=O3BK7iBvsZoodbctepiqUigwSp5FsY9d8nyy97qpIt/TTeDG5acDEccqrWigEUU6gN6vXrdODYhKwdRb8029bPhFpdJCDWMhGdRUVYnyqbqGHs8zHf2+L/zibQOcUg413h5eYfVOHqCrIZYQiytvYLe7VYakIVBhtp+dWzboog0AbyhNiS04qCJiAUcFbKvmy+ZCMgZ5rkpbqvH/7T6Cc7l6yUcprCK31NVTMy4zh1vpZu6A33B/LVwnuJozqAfCA4GBVMU4A7yS0XLmFcbFgX6buF3MRBr/eqm6k9pno0yg3I93AZOEjAX2SY/OLj6P5TY/sgGMD7K1+axoQQA+sA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jSuHP3GBaE1fg98lgJURIpB8431AkMQutWepoB4Lb3PS1R145eSRnkRSZeCO9xFEW33zxNA1chdSuCY8dKYpxBZGgokIeKQh/dTYwZTeZq+WMi8kZU2ijjAilXuz/i/SRraBPtqH4LlM++BvaKzkqUlheWgW2lrj3z0XNlFKUZnw0ViZjbyhvXofM+Tphdj1Zep7YPolfcWuDHLqMR9Tx9igtX1QP01xc4VpPfKip1W2qvMW5VcN0YE3Egg5As6ohvbVbSNY4h11uvApTjNiI6FKo8loI3/E/Bn4U2qYT7N6WtIqysEkuxCGT8+91verBOv4hZveG6Sv0B0tG9cR/A==
  • Authentication-results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
  • Cc: "julien@xxxxxxx" <julien@xxxxxxx>, "George.Dunlap@xxxxxxxxxxxxx" <George.Dunlap@xxxxxxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, "iwj@xxxxxxxxxxxxxx" <iwj@xxxxxxxxxxxxxx>, "wl@xxxxxxx" <wl@xxxxxxx>
  • Delivery-date: Fri, 24 Sep 2021 16:50:27 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHXrkSKbARHP/AzFEumZlsoMq5Uf6uza/QA
  • Thread-topic: [PATCH v2 02/12] xen/memory: Remove tail padding from TRC_MEM_* records

On Mon, 2021-09-20 at 18:25 +0100, Andrew Cooper wrote:
> Four TRC_MEM_* records supply custom structures with tail padding,
> leaking
> stack rubble into the trace buffer.  Three of the records were fine
> in 32-bit
> builds of Xen, due to the relaxed alignment of 64-bit integers, but
> POD_SUPERPAGE_SPLITER was broken right from the outset.
> We could pack the datastructures to remove the padding, but
> xentrace_format
> has no way of rendering the upper half of a 16-bit field.  Instead,
> expand all
> 16-bit fields to 32-bit.
> For POD_SUPERPAGE_SPLINTER, introduce an order field as it is
> relevant
> information, and to match DECREASE_RESERVATION, and so it doesn't
> require a
> __packed attribute to drop tail padding.
> Update xenalyze's structures to match, and introduce xentrace_format
> rendering
> which was absent previously.
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Dario Faggioli <dfaggioli@xxxxxxxx>

Thanks and Regards
Dario Faggioli, Ph.D
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)

Attachment: signature.asc
Description: This is a digitally signed message part



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.