[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 1/2] xen-pciback: prepare for the split for stub and PV

  • To: Jan Beulich <jbeulich@xxxxxxxx>, Oleksandr Andrushchenko <andr2000@xxxxxxxxx>
  • From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
  • Date: Mon, 27 Sep 2021 07:35:33 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=9nSSwAihiXK3S+MOrY7xQjjBWbyyoTUWXuyU+f9frco=; b=mHr1xj4TdNDUj9M87Ahuc4z12poAoh8HSA4EnBAAz+cDPQ7ITcySEHwGzD8bf5swXrOyf1z7s9AECrWOhbYINV1hyM0CIhh1y756wQ9ImYFbcU5wcqAPnQfEuoHHJu1Pah1aL3Wz4PYMDyY+u0Czd/dQipfGea11AtSqmGq+tJiw50V58nwU0J3K+lHawsGCtKUqFzHjXb76/A3VX70oXgvRrN6jSrCDWhOEZ8hDlnTJWuOx/zXA3/YgHz/u3TCoApjW6sZL8c82AaDx635q0QTu7XcC73vXEHVdeNzL0+yxDj1ntwJxyJYC/vY8SHXOQfkLNMXkXg88KJyJIIS32g==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CPIKHTqGkPEpCx9R6pCch7gdELFMyCQ1PEg4uilZXUze9m1QxT+WcS+tUBJaiDOde2gkx7G/eJOYolKJlkIQD5/i7zt5nPRDxS21shJgZihdb3XLPAgLfJjD46bd1WrjRoHCcGVYQaLhrkatLfVcCir4Z+5w3/dM6NOKe3ufL/bzsxO4HTD2uq6GKGxq+lLOfCTZvSKu6J5LLCe3LMriWtPPe7Gu0v/CjW1tTWL5ifDx5YiTUnRIQ/RnT6gmSDDBV8VQE1n8yNVOyqMyI4zbD6oIfAtd9eRBZHEHWwaSvoXQValc8mO5SBg7h5kl0PbJSa5qBi6bvfEn7Rhs9WaMtQ==
  • Authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=epam.com;
  • Cc: "boris.ostrovsky@xxxxxxxxxx" <boris.ostrovsky@xxxxxxxxxx>, "jgross@xxxxxxxx" <jgross@xxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>
  • Delivery-date: Mon, 27 Sep 2021 07:35:47 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHXs20TiZWMfq6cRkakGi7ds9CK56u3ezoAgAACbAA=
  • Thread-topic: [PATCH v4 1/2] xen-pciback: prepare for the split for stub and PV

On 27.09.21 10:26, Jan Beulich wrote:
> On 27.09.2021 08:58, Oleksandr Andrushchenko wrote:
>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
>> Currently PCI backend implements multiple functionalities at a time.
>> To name a few:
>> 1. It is used as a database for assignable PCI devices, e.g. xl
>>     pci-assignable-{add|remove|list} manipulates that list. So, whenever
>>     the toolstack needs to know which PCI devices can be passed through
>>     it reads that from the relevant sysfs entries of the pciback.
>> 2. It is used to hold the unbound PCI devices list, e.g. when passing
>>     through a PCI device it needs to be unbound from the relevant device
>>     driver and bound to pciback (strictly speaking it is not required
>>     that the device is bound to pciback, but pciback is again used as a
>>     database of the passed through PCI devices, so we can re-bind the
>>     devices back to their original drivers when guest domain shuts down)
>> 3. Device reset for the devices being passed through
>> 4. Para-virtualised use-cases support
>> The para-virtualised part of the driver is not always needed as some
>> architectures, e.g. Arm or x86 PVH Dom0, are not using backend-frontend
>> model for PCI device passthrough. For such use-cases make the very
>> first step in splitting the xen-pciback driver into two parts: Xen
>> PCI stub and PCI PV backend drivers.
>> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
>> ---
>> Changes since v3:
>> - Move CONFIG_XEN_PCIDEV_STUB to the second patch
> I'm afraid this wasn't fully done:
>> --- a/drivers/xen/xen-pciback/Makefile
>> +++ b/drivers/xen/xen-pciback/Makefile
>> @@ -1,5 +1,6 @@
>>   # SPDX-License-Identifier: GPL-2.0
>>   obj-$(CONFIG_XEN_PCIDEV_BACKEND) += xen-pciback.o
>> +obj-$(CONFIG_XEN_PCIDEV_STUB) += xen-pciback.o
> While benign when added here, this addition still doesn't seem to
> belong here.

My bad. So, it seems without CONFIG_XEN_PCIDEV_STUB the change seems

to be non-functional. With CONFIG_XEN_PCIDEV_STUB we fail to build on 32-bit


What would be the preference here? Stefano suggested that we still define

CONFIG_XEN_PCIDEV_STUB, but in disabled state, e.g. we add tristate to it

in the second patch

Another option is just to squash the two patches.

> Jan



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.