[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH v4] xen: rework `checkpolicy` detection when using "randconfig"

  • To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 28 Sep 2021 15:46:01 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=1e2UxGNhGpbeevwfItRHbrV3DJCtEnSX9HXGLkrSQ9I=; b=eqSih81HK8/FDD/Opcjfa9pACtbXY7EOb7TrHvJB+irtkb+etbG5qWVVBnyuE5iJsAkJu3xB90rhluviOS73K371JOfa/L6sbcIflJZGgWaexGlMRVT+GqX9XxJwx/o3ZrzIZX+zZmvvZwCPu0z0xfjFngBF6+QWc+ipopcJBTdDjf5fXYILrfyl9gpKAA0s1qMrwlaOVuOIPt7gJFitaBDJbt3lIOHTmlIAO51Bt+xpx/Wj2jHgzUG3u3e3TbKafv6H4ddwj7a4BNAoLFxgJMy8574bbD0fjmzfRlPw339fy5lLWWoY6CyK4nqvs2evCpE0VpUodRQ2CAfPU7CIEw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WqS3WpDWRSs45zAbeS693Fy1rEAiKB9wL63hP6h/tbxM0OHlsUVhz1XgEh+PJwpAoZ8ls2Hehl2Xim+TlOKRZeKd1xMoBGNfRAKOyvc8qmHWPhe5o5ERPX8vEM+ruLmtxm/ObnzBrh6FvRXXEV75logO2Lv/9jfSos4tZ1801qFkjcghgEATJtSYb1ubddmdVUGdkRVplCoJP+Np6P6Rl0MSh+r2WI5uelNTPOlSYwFfRateSULeE0sGXmlfZn7whhG7SZkLssWKWFFqw7Uy8PRbfqD2iyv2BDWjcYYF9NpGEodFx8stXeLzuRLH3YTSIyvnHQtENFFKvieqJG6AUw==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Tue, 28 Sep 2021 13:46:13 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 28.09.2021 10:39, Anthony PERARD wrote:
> This will help prevent the CI loop from having build failures when
> `checkpolicy` isn't available when doing "randconfig" jobs.
> To prevent "randconfig" from selecting XSM_FLASK_POLICY when
> `checkpolicy` isn't available, we will actually override the config
> output with the use of KCONFIG_ALLCONFIG.
> Doing this way still allow a user/developer to set XSM_FLASK_POLICY
> even when "checkpolicy" isn't available. It also prevent the build
> system from reset the config when "checkpolicy" isn't available
> anymore. And XSM_FLASK_POLICY is still selected automatically when
> `checkpolicy` is available.
> But this also work well for "randconfig", as it will not select
> XSM_FLASK_POLICY when "checkpolicy" is missing.
> This patch allows to easily add more override which depends on the
> environment.
> Also, move the check out of Config.mk and into xen/ build system.
> Nothing in tools/ is using that information as it's done by
> ./configure.
> We named the new file ".allconfig.tmp" as ".*.tmp" are already ignored
> via .gitignore.
> Remove '= y' in Kconfig as it isn't needed, only a value "y" is true,
> anything else is considered false.

Seeing you say this explicitly makes me wonder - is this actually true?
At least when modules are enabled (which our kconfig is capable of even
if we don't use that part of it), "m" is also "kind of" true, and the
related logic really isn't quite boolean iirc.

Everything else looks goot to me now, thanks.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.