[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH V3 1/3] xen: Introduce "gpaddr_bits" field to XEN_SYSCTL_physinfo

On 28.09.21 09:28, Michal Orzel wrote:
Hi Oleksandr,

Hi Michal

On 24.09.2021 00:48, Oleksandr Tyshchenko wrote:
From: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>

We need to pass info about maximum supported guest address
space size to the toolstack on Arm in order to properly
calculate the base and size of the extended region (safe range)
for the guest. The extended region is unused address space which
could be safely used by domain for foreign/grant mappings on Arm.
The extended region itself will be handled by the subsequents

Use p2m_ipa_bits variable on Arm, the x86 equivalent is

As we change the size of structure bump the interface version.

Suggested-by: Julien Grall <jgrall@xxxxxxxxxx>
Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
Please note, that review comments for the RFC version [1] haven't been 
addressed yet.
It is not forgotten, some clarification is needed. It will be addressed for the 
next version.


Changes RFC -> V2:
    - update patch subject/description
    - replace arch-specific sub-struct with common gpaddr_bits
      field and update code to reflect that

Changes V2 -> V3:
    - make the field uint8_t and add uint8_t pad[7] after
    - remove leading blanks in libxl.h
  tools/include/libxl.h            | 7 +++++++
  tools/libs/light/libxl.c         | 2 ++
  tools/libs/light/libxl_types.idl | 2 ++
  xen/arch/arm/sysctl.c            | 2 ++
  xen/arch/x86/sysctl.c            | 2 ++
  xen/include/public/sysctl.h      | 4 +++-
  6 files changed, 18 insertions(+), 1 deletion(-)

Don't you want to print gpaddr_bits field of xen_sysctl_physinfo from 
output_physinfo (xl_info.c)?

Good point, will do, thank you.

Apart from that:
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>




Oleksandr Tyshchenko



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.