[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 10/11] vpci: Add initial support for virtual PCI bus topology
- To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 29 Sep 2021 11:09:03 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=EAo9xfYpnf8kmt+M2iJxEWkckj4VOOa8jqFTnO/RFFE=; b=EsLn6ZDHf6MwimQJ9e+aLMm7R33ehnTws2YtVkO1nClQFhGGNx/WwYg6y4fxnw5Bxdp1LBzBVQtdRyiG0YuwNPkofyIcdAC969MxLirKj0v/8zl3v1oAuuR+V0u48+iGLTRwhd6AIsEDF1s73ef25vBu+JpZ3iSAClMDITTS2POUCHBEU8QrwfVce8FvDfeJeyrDp6vG+kq3M+Guq/2afL6E9hVWbzHySfWXdIjIFwor1OasR9ScQQMgWBC0QQMf5jxGYEaoseQ/nB9qQYXZl2qKyjugizABvJF4V0oek7iCye9/yVZZSt3adPFGlST8unLFzQs3st1gUcXKo1a8Zw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kF35Gv0J4Rd+qhATvE27RsNhKCBh7JmDiEnpkQcNyBhXy2QJpOwXzkEGSAT5LPnjmBHbflFZI/V1JMmOZRuz6TgJBQKlrBtsnXauMPWDM/KTPOeULa7I5DTgJDNDEFMlpBWOV57gORFhLL2BAteVQCUQ51uzGiFMsdFQvwujTVrNpqnTjchuYblV33jhRzkqbZllDERkTM/4ucvWRvyuWX+RMUjUP0U8w42AeeSTU9e0W735lVmn8BzPIiJv1Zi2M5Ef7C/QvTxA/TQPukYppRWfQPSicyT4fHdfqGhIJPBQvqRMORtf1OV/0yJ3Jsq7oSLCCXqhfRulVhwe5BvplQ==
- Authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=suse.com;
- Cc: "julien@xxxxxxx" <julien@xxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Artem Mygaiev <Artem_Mygaiev@xxxxxxxx>, "roger.pau@xxxxxxxxxx" <roger.pau@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>
- Delivery-date: Wed, 29 Sep 2021 09:09:17 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 29.09.2021 11:03, Oleksandr Andrushchenko wrote:
> Sorry for top posting, but this is a general question on this
> patch/functionality.
>
> Do you see we need to gate all this with CONFIG_HAS_VPCI_GUEST_SUPPORT
> as this renders in somewhat dead code for x86 for now? I do think this still
> needs to be in the common code though.
I agree it wants to live in common code, but I'd still like the code to
not bloat x86 binaries. Hence yes, I think there want to be
"if ( !IS_ENABLED() )" early bailout paths or, whenever this isn't
possible without breaking the build, respective #ifdef-s.
Jan
|
