[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/3] arm/efi: Use dom0less configuration when using EFI boot
- To: Luca Fancellu <luca.fancellu@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 29 Sep 2021 13:53:58 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=8z51UwVKPDWSBfBs3ps8xHTJL4MdVWelWkGkGl6tl3c=; b=PG51bbUGl9fRQsum3lMMKT7fpmPw8TpDsLXgQ/YTeAP/p6lzIgivT8J5rU4ksiJW4kfp/k+/RAjRejTn/CNMFiGabupR9IIihfwCfZFRiOty8YVWP/zmelyH9bnjcKsYEFXs/Po/wjI8DY7dQJ6VkKmfE8hV3TN1TYKnl0TJZrHZ0YPFvTGD5bW8UhlZ28xqVZoRH/eOi34DbMo/RltLumsyctZbFt85v3CU72eRyjMslw+fsJPlRKL9smZCS51wqqqr4JZtiJUwOXHvj8naMHJEDlJhNCOiaARJXb/wDoEFRud4C7ztuY0jmK1PFHSutvJo96e3oy3BPh5hhDWBmQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FAX0+2E76jqnGOi8jd/pBuNipq77Q9K2zrTNL7pJQnpJK0LExgG9N++i+hK7XNEZEDOKx4DpV07jzuCKmClBHtY0B8DqoEFs2QZqXxv3aDKvwf6+iDYJE6SPfnxtVrhw4gPv5wu/T5HZIxMcVjIXnT031S5/rHmBIBwopc2nyQUF3V/3EW8C/tK3tJsPzcYThyzlwJjcsVvh6QpldK4GksWcDkesWiI3citXfy4iOF1+0ZVawbnDxIeClWH7lFPQuH5tqosCmuxxRwHCSB5zLmpBjCYgkwZO1B81ULXPGl0P3mZLAf/cLbQAk3C4s7ibAbl6RDhHe11JQ+1qJZmCag==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Bertrand Marquis <bertrand.marquis@xxxxxxx>, wei.chen@xxxxxxx, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 29 Sep 2021 11:54:23 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 29.09.2021 13:30, Luca Fancellu wrote:
>
>
>> On 29 Sep 2021, at 08:50, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>>
>> On 28.09.2021 18:32, Luca Fancellu wrote:
>>> --- a/xen/arch/x86/efi/efi-boot.h
>>> +++ b/xen/arch/x86/efi/efi-boot.h
>>> @@ -678,6 +678,12 @@ static void __init efi_arch_handle_module(const struct
>>> file *file,
>>> efi_bs->FreePool(ptr);
>>> }
>>>
>>> +static int __init efi_arch_check_dt_boot(EFI_FILE_HANDLE dir_handle)
>>> +{
>>> + /* x86 doesn't support device tree boot */
>>> + return 0;
>>> +}
>>
>> Every time I see this addition I'm getting puzzled. As a result I'm
>> afraid I now need to finally ask you to do something about this (and
>> I'm sorry for doing so only now). There would better be no notion of
>> DT in x86 code, and there would better also not be a need for
>> architectures not supporting DT to each supply such a stub. Instead
>> I think you want to put this stub in xen/common/efi/boot.c, inside a
>> suitable #ifdef.
>
> Sure I will enclose it in #ifdef CONFIG_ARM and remove the x86 stub.
Hmm, so you've taken my reply in way quite different from how it was
meant, albeit I can't see how the last sentence of what I've said could
be interpreted in this way. The more generic stub wants enclosing in
"#ifndef CONFIG_HAS_DEVICE_TREE" imo.
Jan
|
