[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v4 5/6] x86/HVM: skip offline vCPU-s when dumping VMCBs/VMCSes


  • To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 29 Sep 2021 15:15:24 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=/SsiSshy4JYyNEDKdw1hBdETYO6OhRZqVzfvWAITRUY=; b=Lhkk3xVRweitjsrTY7AFdUvT0e1wTNFpMEbBlr9Qs6v+O91JhfpWFFYN9gK5p4OdbEcjbzmKadK+T15GtVyIbcSfIPyWqe7LruY17HvXj7J2mzsnuICoqiCSfzX5/VPFUaj40Al6v7HaYwOcCRKmlTrOK9hx2ReDgvssQBSR98UVzxHBTt4m7PjPZjFy7KRGFm+3PQmJf7ruFT/knuso6c+6I+DXZOrUg14fSnKKCrNJ6sqH1wwcefs+Xje2LL3Uk84F8Dyxm4GmH7oQHFxDRKf2Zu2E98q85e7QEbCHowuA8SoNv9H0HAHP4FaqbfWkrMLOljBEheKgykYsspT5VA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MyPyY0X3CdbrApH4GlNlmy7go66YHNLd1U/FZwWghNZe8U+E5pHT85SoMBQwQwyKOkCyn4V0ErC1KmB++r6Chehn3GDorgYnT+gzfc3EGTqYpGiOqfTurwWXAF9qr0+hSh2Ed49iBGfQZ9uRWjebj7lg9Jw1yjW5kuBTirY1Xjy6H8G2N4alnIodBsNXcu2v9e7UNUag32KPnArIgfDsXivQVOx/dBm0BY4AXorhaoHKFLDjZkNlpVmTY18+S4G7+ku8Cx/vyruvjt8j+5HSfzjBHXgUHYknZfMXOiqJWGexggQD6vv9p8IrDV8/Xpp9TxAa1YYz/nrGgrAGGhb65A==
  • Authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>
  • Delivery-date: Wed, 29 Sep 2021 13:15:32 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

There's not really any register state associated with vCPU-s that
haven't been initialized yet, so avoid spamming the log with largely
useless information while still leaving an indication of the fact.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
---
v4: Key off of v->is_initialised.
v2: New.

--- a/xen/arch/x86/hvm/svm/vmcb.c
+++ b/xen/arch/x86/hvm/svm/vmcb.c
@@ -242,6 +242,11 @@ static void vmcb_dump(unsigned char ch)
         printk("\n>>> Domain %d <<<\n", d->domain_id);
         for_each_vcpu ( d, v )
         {
+            if ( !v->is_initialised )
+            {
+                printk("\tVCPU %u: not initialized\n", v->vcpu_id);
+                continue;
+            }
             printk("\tVCPU %d\n", v->vcpu_id);
             svm_vmcb_dump("key_handler", v->arch.hvm.svm.vmcb);
         }
--- a/xen/arch/x86/hvm/vmx/vmcs.c
+++ b/xen/arch/x86/hvm/vmx/vmcs.c
@@ -2133,6 +2133,11 @@ static void vmcs_dump(unsigned char ch)
         printk("\n>>> Domain %d <<<\n", d->domain_id);
         for_each_vcpu ( d, v )
         {
+            if ( !v->is_initialised )
+            {
+                printk("\tVCPU %u: not initialized\n", v->vcpu_id);
+                continue;
+            }
             printk("\tVCPU %d\n", v->vcpu_id);
             vmcs_dump_vcpu(v);
         }




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.