[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH v2] build: add --full to version.sh to guess $(XEN_FULLVERSION)

Anthony PERARD writes ("[XEN PATCH v2] build: add --full to version.sh to guess 
> Running $(MAKE) like that in a $(shell ) while parsing the Makefile
> doesn't work reliably. In some case, make will complain with
> "jobserver unavailable: using -j1.  Add '+' to parent make rule.".
> Also, it isn't possible to distinguish between the output produced by
> the target "xenversion" and `make`'s own output.
> Instead of running make, this patch "improve" `version.sh` to try to
> guess the output of `make xenversion`.
> In order to have version.sh works in more scenario, it will use
> XEN_EXTRAVERSION and XEN_VENDORVERSION from the environment when
> present. As for the cases were those two variables are overridden by a
> make command line arguments, we export them when invoking version.sh
> via a new $(XEN_FULLVERSION) macro.
> That should hopefully get us to having ./version.sh returning the same
> value that `make xenversion` would.
> This fix GitLab CI's build job "debian-unstable-gcc-arm64".
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Reviewed-by: Ian Jackson <iwj@xxxxxxxxxxxxxx>



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.