[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 05/11] xen/arm: Mark device as PCI while creating one
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
- From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
- Date: Fri, 1 Oct 2021 07:11:58 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FOaDHZkgcRQbYueAnxlvdHHKOop6q82+9hNK1tPzRDo=; b=GQ/SIgloxGbKUzrS9r2PydxcHumQ/NuNnvsU8XYALyw0t0/8a4nuvWn8pKb0JNk5R23yl+jQ7n8C7RaHZaYuqzz0w7bwmU8TygrsMQEa8kjjPqmHJP+RrqdcOttdcik5KVK8U9PuqMXYgEPMYGZpoKI2+5W4dVLf4s9q/Xw5cJH2pslpQQt7/uTohV75ez9bWw3qT2852ecX65Gn2glt98vKawXoMvY88/ibZmoA3mc9zSdWB6gUNLbC6h9dnFIMo0hhYdic0XN5VCk4JiE3Nx5sE5/mRzIu6XEvH8zaWI9xmXvgzadPJz0GUXz956+jDWimVDznC0BKyWV1YFhsHw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TyFOx7v7Mx+h+Ll5M1j1rA2/44gTVpwNfiQcpmHK+Q+cUn4kfkrL7YPMjPYnhuiZtFZCSKQbnfg1CKn5Noa4U8rS/umCrRLzQeslna89Dk+KgchvrDdlodz+WCqtH79g+jyTwrSiPJ33L7819wfSR6o+EKXvoZZ660kXPz7gPDN1xDKfXj9CZauWqe1ml9XNHnLQqkQTLp0CqQxwj2MvUfP/IE24Lch5EvoDf8uxCebrit69D3RtF6pu9skdJCqRt0Tqv3OSG8BDfrq7i1SMaMoIsd6Y9850GdI7/FeMyOXvkt0i2OdCyvWuYvg0YOvgPZWReT7pNp4UfwfRg0X1qw==
- Authentication-results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=epam.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>, Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Artem Mygaiev <Artem_Mygaiev@xxxxxxxx>, "roger.pau@xxxxxxxxxx" <roger.pau@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>, Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
- Delivery-date: Fri, 01 Oct 2021 07:12:22 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHXtcqxBmbIjyoLuU2towH4iHJ8hau9TJiAgABvEQA=
- Thread-topic: [PATCH v3 05/11] xen/arm: Mark device as PCI while creating one
On 01.10.21 03:34, Stefano Stabellini wrote:
> On Thu, 30 Sep 2021, Oleksandr Andrushchenko wrote:
>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
>>
>> While adding a PCI device mark it as such, so other frameworks
>> can distinguish it from DT devices.
>> For that introduce an architecture defined helper which may perform
>> additional initialization of the newly created PCI device.
>>
>> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
> I get a build failure without CONFIG_PCI on ARM64:
>
> In file included from /local/repos/xen-upstream/xen/include/xen/pci.h:66:0,
> from /local/repos/xen-upstream/xen/include/xen/iommu.h:25,
> from /local/repos/xen-upstream/xen/include/xen/sched.h:12,
> from arch/arm/arm64/asm-offsets.c:9:
> /local/repos/xen-upstream/xen/include/asm/pci.h:127:46: error: ‘struct
> pci_dev’ declared inside parameter list will not be visible outside of this
> definition or declaration [-Werror]
> static inline void arch_pci_init_pdev(struct pci_dev *pdev) {}
> ^~~~~~~
> cc1: all warnings being treated as errors
Ah, this then needs to be
struct pci_dev;
static inline void arch_pci_init_pdev(struct pci_dev *pdev) {}
Jan, as this is going to be Arm change, so can I keep your Ack please?
Thank you,
Oleksandr
|
