[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH V4 1/3] xen: Introduce "gpaddr_bits" field to XEN_SYSCTL_physinfo

  • To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Fri, 1 Oct 2021 09:50:52 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FS3M77QyqTSgF3aukoaB+MKaXGKK9/uwme7/4adiMq8=; b=l3IagNSjf1b4LewabkJfzyGeYll9rZo2ms2KLpvjTq4cwKegFpw/8C8zsEK9tCyvsbGfdEzdl2BCve6qpZpgDv74ZZ7Re5AvVpNqzCy2aONulZ+i7Tt+GmFVK/poBwNvxTkMDxYROItgss+BM2+LYDSlvjIVH0rJHHlZLxOiR/HCHoJfZz9AxBC5kr8UbVwEuQfJKnIQBko+r8FWOuz9w78GreJiQXjVgd0wRSLsuLABeucKYiTCmsELJQWz2lNaep4ktlAMxg5yr8s0a+aPinJftqaKl9xMVELXMW8QfSYGavIwvBQdBddeNjtQr003o7DFK9LjsksmRWwxk2nHpg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cP7m0WWF6up00OpUH/RaMfpwIDB5Y9Iu+sxHjBe9NvakzWEg/Zm5X/r55s38tQQ5EHZeg4hC0yOCoVK979xV9sU4uueHiGFqime8vYSpwT9tdSRxMtswbg5B/soQLdzm/KOrwBxo8AOzJq4wCBGv0qX8XnN+9yxEnKkOqmZej5vBFrGDFT67/PxXCIZW97KqXIB3qErN8lO8I8k0eCci3Fr4QbpfrS/p2bw9FSQnwB9ijjNG99ZO3l6uz2U5C2qtJY+Umr/c1AgKtLol+5vujinWB6Yp7msFIiMJh0L2C9kfbuQ27RKJJWGH8mT+vKPAnSDYRbQNu7zIcSgdk5danA==
  • Authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=suse.com;
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Oleksandr Tyshchenko <olekstysh@xxxxxxxxx>
  • Delivery-date: Fri, 01 Oct 2021 07:51:13 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 01.10.2021 01:00, Stefano Stabellini wrote:
> On Thu, 30 Sep 2021, Oleksandr Tyshchenko wrote:
>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
>> We need to pass info about maximum supported guest address
>> space size to the toolstack on Arm in order to properly
>> calculate the base and size of the extended region (safe range)
>> for the guest. The extended region is unused address space which
>> could be safely used by domain for foreign/grant mappings on Arm.
>> The extended region itself will be handled by the subsequents
>> patch.
>> Use p2m_ipa_bits variable on Arm, the x86 equivalent is
>> hap_paddr_bits.
>> As we change the size of structure bump the interface version.
>> Suggested-by: Julien Grall <jgrall@xxxxxxxxxx>
>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
>> Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>

I have to admit that I'm a little puzzled to see these R-b-s when ...

>> Please note, that review comments for the RFC version [1] haven't been 
>> addressed yet.
>> It is not forgotten, some clarification is needed. It will be addressed for 
>> the next version.
>> [1] 
>> https://lore.kernel.org/xen-devel/973f5344-aa10-3ad6-ff02-ad5f358ad279@xxxxxxxxxx/

... Oleksandr makes clear this patch isn't really ready yet. The tags
could misguide a committer into putting in this series despite the
open issue(s).




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.