Re: [PATCH v5 2/3] usb: Introduce Xen pvUSB frontend (xen hcd)

[Juergen Gross <jgross@xxxxxxxx>]

On 01.10.21 17:13, Greg Kroah-Hartman wrote:
> On Fri, Oct 01, 2021 at 05:00:38PM +0200, Juergen Gross wrote:
> > --- /dev/null
> > +++ b/drivers/usb/host/xen-hcd.c
> > @@ -0,0 +1,1641 @@
> > +/*
> > + * xen-hcd.c
> Need a SPDX line here, instead of the license boiler-plate text you
> have.
>
> Did you run checkpatch on this thing?  I thought that would have told
> you about this.
>
> > + *
> > + * Xen USB Virtual Host Controller driver
> > + *
> > + * Copyright (C) 2009, FUJITSU LABORATORIES LTD.
> > + * Author: Noboru Iwamatsu <n_iwamatsu@xxxxxxxxxxxxxx>
> > + *
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License as published by
> > + * the Free Software Foundation; either version 2 of the License, or
> > + * (at your option) any later version.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> > + * GNU General Public License for more details.
> > + *
> > + * You should have received a copy of the GNU General Public License
> > + * along with this program; if not, see <http://www.gnu.org/licenses/>.
> > + *
> > + * Or, by your choice:
> > + *
> > + * When distributed separately from the Linux kernel or incorporated into
> > + * other software packages, subject to the following license:
> > + *
> > + * Permission is hereby granted, free of charge, to any person obtaining a copy
> > + * of this software and associated documentation files (the "Software"), to
> > + * deal in the Software without restriction, including without limitation the
> > + * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
> > + * sell copies of the Software, and to permit persons to whom the Software is
> > + * furnished to do so, subject to the following conditions:
> > + *
> > + * The above copyright notice and this permission notice shall be included in
> > + * all copies or substantial portions of the Software.
> > + *
> > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> > + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> > + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
> > + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> > + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
> > + * DEALINGS IN THE SOFTWARE.
> Dual licensing a USB host controller driver is, um, a very dubious
> thing given that you can only interact with symbols exported with
> EXPORT_SYMBOL_GPL() from the USB stack.
>
> So you might want to change this...
Ah, right. I thought I wouldn't be able to do so, as the original driver
was including above license text, but reading it again I think I can
just make it GPL-V2.


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature