[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/9] x86/xen: print a warning when HVMOP_get_mem_type fails
- To: David Hildenbrand <david@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx
- From: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
- Date: Tue, 5 Oct 2021 15:30:25 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hagq3upWVQMX0uoE2qylRWfS6OLtiOzrGNSqBcp1/dM=; b=ZwP2jGr4NSEyEL6oMUcxm9QrVokbwf6aD9Kp+jK+X5Vi17PaCnGuo0UHF8m8yGbsS3DPdH54GWvI8yIFXknL/1yw0YrQnea0q1hnJlqJ3WCA3D3OEpNnhev/WatLpmStAaifoUp7ntvceV2j+aEJFy5hNq+WtwgX0LwqwgotxQnf9gW+PpSJcGoFrC1KFUdCOy9o4xkZmIO9TjIRYMt7FXnSqjWp9gDE8kRf3KHLgasG4koQPLAjjE1epz4u1ebHZ8qQFKx9iaO4vT7dgYEORMYrWDWV80OvJFEFP2Af0aC5M5FvtDfBLrsl8r0Qr+ebPrcDIqy+2gfbY7wNNqBpEQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GhG+CHmJv+g13mSyIzn+Q/QOfO3dtXQO6YwGC4re9MHNraMS68qvxKK9wNr7mRkjR+ObY+cHxU0L8QeazjVcZ68XKYrzxkGyFU+/8/WmFDuA/i0C026gpMh3j3kefZY/zTbCwsSTQbTSlkY/10mMqo8UHfHTwcsl3aiCM4sqoEcf1864TlS060yeWs91LJbTlljO3NjJn76AIWl2td7fjOySkVkMuWsfs3Dj5fk8UM/qwGVZmEJ8RizLgqUd3jFwqe4DG3nqtdjwsglnoW9M6ltJuokBRi7LEa3OVkfpLlMgi8dzROX+FZK2U0/cuR7JniEetBH/cC/fJLaDVs4JrA==
- Authentication-results: kvack.org; dkim=none (message not signed) header.d=none;kvack.org; dmarc=none action=none header.from=oracle.com;
- Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Jason Wang <jasowang@xxxxxxxxxx>, Dave Young <dyoung@xxxxxxxxxx>, Baoquan He <bhe@xxxxxxxxxx>, Vivek Goyal <vgoyal@xxxxxxxxxx>, Michal Hocko <mhocko@xxxxxxxx>, Oscar Salvador <osalvador@xxxxxxx>, Mike Rapoport <rppt@xxxxxxxxxx>, "Rafael J. Wysocki" <rafael.j.wysocki@xxxxxxxxx>, x86@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx, kexec@xxxxxxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx
- Delivery-date: Tue, 05 Oct 2021 19:31:01 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10/5/21 8:14 AM, David Hildenbrand wrote:
> HVMOP_get_mem_type is not expected to fail, "This call failing is
> indication of something going quite wrong and it would be good to know
> about this." [1]
>
> Let's add a pr_warn_once().
>
> [1] https://lkml.kernel.org/r/3b935aa0-6d85-0bcd-100e-15098add3c4c@xxxxxxxxxx
>
> Suggested-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
> Signed-off-by: David Hildenbrand <david@xxxxxxxxxx>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
|
