Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree node in libxl

[Ian Jackson <iwj@xxxxxxxxxxxxxx>]

Rahul Singh writes ("Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree 
node in libxl"):
> libxl_defbool_val(libxl_defbool db) is implemented in such a way that it will 
> assert 
> if db value is the default. Therefore we have to explicitly set it to 
> LIBXL__DEFBOOL_FALSE for x86.
> 
> There are two option either we can have #ifdef or we can move the 
> libxl_defbool_setdefault(&b_info->arch_arm.vpci, false) to common code.

What is wrong with putting it in
libxl__arch_domain_build_info_setdefault
which I think exists precisely for this kind of thing ?

Ian.