[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 10/11] arm/libxl: Emulated PCI device tree node in libxl
- To: Rahul Singh <rahul.singh@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Julien Grall <julien@xxxxxxx>
- Date: Wed, 6 Oct 2021 20:01:15 +0200
- Cc: bertrand.marquis@xxxxxxx, Andre.Przywara@xxxxxxx, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Wed, 06 Oct 2021 18:01:29 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Rahul,
On 06/10/2021 19:40, Rahul Singh wrote:
diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
index 3f9fff653a..78b1ddf0b8 100644
--- a/tools/libs/light/libxl_types.idl
+++ b/tools/libs/light/libxl_types.idl
@@ -644,6 +644,7 @@ libxl_domain_build_info = Struct("domain_build_info",[
("arch_arm", Struct(None, [("gic_version", libxl_gic_version),
("vuart", libxl_vuart_type),
+ ("vpci", libxl_defbool),
I have posted some comments regarding the field in v4. To summarize,
AFAICT, this option is meant to be only set by libxl but you still let
the toolstack (e.g. xl, libvirt) to set it.
If you still want to expose to the toolstack, then I think the option
should be outside of arch_arm. Otherwise, this should be moved in an
internal structure (Ian, do you have any suggestion?).
Cheers,
--
Julien Grall
|
