[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/3] xen+tools: Introduce XEN_SYSCTL_PHYSCAP_vpmu
- To: Michal Orzel <michal.orzel@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 7 Oct 2021 09:59:04 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=14jtNC+yODdnQcK/dhmt/nz3nPzJMnSeA4g3gldk2+o=; b=ZrzmrA8YNY20M7Tr/qAcHxu/LtJSDtySF4Ha7kyMg4Sg3s+hcHD5EQpDl0TD0NrsxB2FHFur5jbMqAhcTzNpwOQXSVc9eDedaQfc6kj3uDpD1QENG47AodNMbxz0QSaI6r8B9bS7ujFlHIW1VfKVqpfec5zJyv2mn7KW51dLvvP3WETK1vM1RwszmqgCAD+LKx6g6pG1/94jJKua8CE501G5oAOO+7k5+aB6kkN1nqmALMcCjAD8ilK8AZ+KWUUZCYIDTjkvJYkZLBCl+5r64LD6ka7ERh4Xb3cRwsNaGtkgWPxZ5jQ1baSNFvzu6//M4kP2j8dWiSNoyNqkjn6/vw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h/5F9ZmvcWTg5NFiTJSns8T9NaWLRRT8cV0SuYPpL5HZcuooSoxTG8VpdGgLftNdhxSk9ZFQBJUWJTfZH5+C+Xpno+eLCXD7MjiPLXz/m4/NgboYR/FmFkEGbi2Zwc9smUjKD8UuKZqUXSkBJq+sRoltWx/toAzJti1og/NeC4z/iJ5h4B+bcF5iB2oXnJkqXcOaE+Lk8joR1nbh1tuspZq6Q76B/WPlYqBEYYtmifs3R6GV5beGXls0K/oaY9yVGQHJvJ9gcNGPXxhRWFAYp5sZF6TcxvZkbOyXygrYmCvX/FDpg5MziQccTzvarVmT3j4bVo+9KZ1duLVH32/0FA==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: George Dunlap <george.dunlap@xxxxxxxxxx>, Nick Rosbrook <rosbrookn@xxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Christian Lindig <christian.lindig@xxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, bertrand.marquis@xxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 07 Oct 2021 07:59:29 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 06.10.2021 12:58, Michal Orzel wrote:
> Introduce flag XEN_SYSCTL_PHYSCAP_vpmu which
> indicates whether the platform supports vPMU
> functionality. Modify Xen and tools accordingly.
>
> Take the opportunity and fix XEN_SYSCTL_PHYSCAP_vmtrace
> definition in sysctl.h which wrongly uses (1<<6)
> instead of (1u<<6) and does not follow the standard
> of using separate macro for a flag field.
While adding the u suffix is fine with me, iirc not introducing
_XEN_SYSCTL_PHYSCAP_vmtrace was a specific review request at the
time. I would similarly ask to avoid introduction of
_XEN_SYSCTL_PHYSCAP_vpmu here, for it not being consumed by
anything other than XEN_SYSCTL_PHYSCAP_vpmu's definition.
Jan
|
