[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 03/11] xen/arm: Add cmdline boot option "pci-passthrough = <boolean>"
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Rahul Singh <Rahul.Singh@xxxxxxx>
- Date: Thu, 7 Oct 2021 08:32:44 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NY7T2DMdrP8QbJjXTPcEhoExl6C7BaRglfaB2gl/xI8=; b=aE4JqPNqstETmeGecq8QLX/yhGDNXlnoAn4vX7gnChCYMsGQX58MD0SCg3YCJW8otoTUXlqE9YOpEAB2sUR56HfwL8t2ZmiUC1/fGzJP0ymmGDUYVSYl3ukBwoKP/DzpqcEt4Cv5+mfkM2L/5gi6K02nsr/7b2l6BA60B7CCLfzViXx0ifCChW08y8CiNeaRzym+jpEjuBKr4VVKKO/qkChUUKpeZ9+qG1u5Amft+5MvdKaPuCJsF7U0s/MVC0PVbFqxjzbhd7hM3pYgG/cXzFYAoU+MJ4ighjs1HHLzCgHpemKlIDuYPkBvyo1f05NIYcYzC9VlOl1syyRRSpP9ZQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=grgd9oRAlxgdt02lXCWTz+R9p2jHT4QM5gDQlfJSJPORk3tl4GzTIpoj41La4qZdxxEEKLHodqWSSDDy8Z1sPoRES1vOI49urAWD0rYSRIvB03sLPMsgzvLSisIPGK4QjYc1RVL4NXTBNwRHcLaCI81AWNKWl+9I2zeoBcVsqUIp7jTiBl/g74dvBkDv9/SaeDdHPCYXI/pzyXSlUunayXN8E5NJoSsmIy29GuAwNvn2CAyUwGIGe/N0oyhrElvO5xD7Y8rTb7Qr5IklPXJSbuEOkhrcCKd8wccOP7OALlubaCBB2oTuMqqYhgUUNLyMbqdXMP1BoLosL27qOPlo2w==
- Authentication-results-original: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
- Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Andre Przywara <Andre.Przywara@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 07 Oct 2021 08:33:08 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHXutl8uDaCKdGiUEea3YjyaYprAqvHNJaAgAABgwA=
- Thread-topic: [PATCH v5 03/11] xen/arm: Add cmdline boot option "pci-passthrough = <boolean>"
Hi Jan,
> On 7 Oct 2021, at 9:27 am, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 06.10.2021 19:40, Rahul Singh wrote:
>> @@ -62,8 +63,19 @@ static int __init acpi_pci_init(void)
>> }
>> #endif
>>
>> +/* By default pci passthrough is disabled. */
>> +bool __read_mostly pci_passthrough_enabled;
>
> You properly use "bool " here. Why ...
>
>> --- a/xen/include/asm-arm/pci.h
>> +++ b/xen/include/asm-arm/pci.h
>> @@ -19,14 +19,25 @@
>>
>> #define pci_to_dev(pcidev) (&(pcidev)->arch.dev)
>>
>> +extern bool_t pci_passthrough_enabled;
>
> ... the being phased out "bool_t" here?
I missed that I will fix this.
Regards,
Rahul
>
> Jan
>
|
