[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 1/3] xen+tools: Introduce XEN_SYSCTL_PHYSCAP_vpmu
- To: Michal Orzel <michal.orzel@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 8 Oct 2021 10:33:36 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6aCodjr1taws3K6Jb047WlFcwqBmnnBnKcuBfc1FYIU=; b=FLW1Mynvr5AJLqKjXgIv8rWnCH/JII83ZC6kDDZO2RQc37qVDrGMvA+bKyO3V9hD1WX/93lLh0vKHQDtrPaa19AEbQGNXaf0XxPNWuZWxhCt0t4EqfVPbhT5drLkz7nHo7wAO9iCpQN0JpmTDbKbP4s++/yPzf75FzrQnL+PApIPju9uBElJNL+QydgbSoYeS6wWioIYAodfXj1L8iSjAasXvkn6ELKNtAVYnJSigvRKWIxc/BmQJUlxKM3bAqHvkC3ypHRxG4mV1UJfPoRDzup/C9677zpB3d6nn2wSSUXDXPNcCjDNVBDyZIGMR9OfwtVfx+mNr2daWZicmD10ZQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MZ7e3qOf/L8oKKUnGmVKTv/5njco9B5o9N+Km1qF/+0rkScDJDoGnr4IHgW9Xb0DfC+VGm/K4gQPUSmAvZE+79V/aK5nlaS3k4QwvYVwgJzFG89E8VtRN9dgTGGJ4LuDETNRLXwPYif2HNKgUOeGRg1Q30bbfn38CRZZh/qOyB5xtyXqkDGeb1JPlZnvwGmw6jKzbCQvXFzzay1xWH35Ln+0dN3Wv1lQmq2sh2JLmMTgdFPIt6xPelJPhVkD4V1F47bdGs+p1JpbdxhpQ2SZtwkOIVdxzQnx05wZgcHUnBdnk3g7t0f81wAnPWXzehoY+5D4AUOJrvQ7ZPr8+GKZvQ==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: George Dunlap <george.dunlap@xxxxxxxxxx>, Nick Rosbrook <rosbrookn@xxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Christian Lindig <christian.lindig@xxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 08 Oct 2021 08:33:49 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 08.10.2021 10:19, Michal Orzel wrote:
> --- a/xen/include/public/sysctl.h
> +++ b/xen/include/public/sysctl.h
> @@ -100,10 +100,12 @@ struct xen_sysctl_tbuf_op {
> #define _XEN_SYSCTL_PHYSCAP_iommu_hap_pt_share 5
> #define XEN_SYSCTL_PHYSCAP_iommu_hap_pt_share \
> (1u << _XEN_SYSCTL_PHYSCAP_iommu_hap_pt_share)
> -#define XEN_SYSCTL_PHYSCAP_vmtrace (1 << 6)
> +#define XEN_SYSCTL_PHYSCAP_vmtrace (1u<<6)
> +/* The platform supports vPMU. */
> +#define XEN_SYSCTL_PHYSCAP_vpmu (1u<<7)
While purely cosmetic and easily fixable while committing, I still
fail to understand why you did drop the blanks from the expression
you adjust and why you didn't add blanks to the new expression.
./CODING_STYLE is quite clear in this respect, and even the code
in context does not suggest any alternative style. (While code just
outside of visible context does, it should not be used as excuse
to introduce further style violations.)
Jan
|
