[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/build: suppress EFI-related tool chain checks upon local $(MAKE) recursion


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Date: Fri, 8 Oct 2021 12:09:03 +0100
  • Authentication-results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Andrew Cooper" <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Fri, 08 Oct 2021 11:09:36 +0000
  • Ironport-data: A9a23:LggiqKMo7wf7SDjvrR1rkMFynXyQoLVcMsEvi/4bfWQNrUoi1DMBz 2YdC2GDMviDajf0e9wlbo/g9kkGvJHWmtNiHQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6ZUsxNbVU8En540Uozw7dRbrNA2rBVPSvc4 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYowyPksAt2 fNsjt+9Rx4kb4OTmfY4TjANRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs 6VFdnZdNXhvhMrvqF6/YuBqmsQkKtitJI4Fs2ts5TrYEewnUdbIRKCiCdpwgWtu1pEeRKu2i 8wxQztsZQjYPkd1MGwuLKhvpsqxhnDWWmgNwL6SjfVuuDWCpOBr65DyNPLFd9rMQt9a9m6Iq 2SD82nnDxUyMN2E1SHD4n+qnvXIny7wRMQVDrLQ3vxgjUCXx2cTIAYLTlb9qv684nNSQPoGd RZSoHB36/Fvqgr7FbERQiFUvla9uBMMB8t2MtZ55Q+Ux/v6vAeLI3UtG2sphMMdiOc6Qjkj1 1msltzvBCByvLD9dU9x5ot4vhvoZ3FKfDZqiTssCFtduoa/8OnfmzqVFr5e/LiJYsoZ8N0a6 x6NtjR2o7wOgcMR26y/8DgraBr3/cORH2bZCujNN19JDz+Vhqb5OeRECnCBtJ6sybp1qHHa5 xDofODEvIgz4WmlznDlfQn0NOjBCwy5GDPdm0VzOJIq6i6g/XWuFagJvmolehwzaZ5UIGezC KM2he+3zMQIVJdNRfUnC79d9uxwlfSwfTgbfqq8giVyjmhZK1bcoXAGib+41GHxikk8+ZzTy r/AGftA+U0yUPw9pBLvHr91+eZymkgWmDOCLbimnk/P+efPOxaopUItbQLmghYRt/jf/m04M r93aqO39vmoeLSmOHeIqtRPcQliwLpSLcmelvG7v9WremJOcFzNwdeKqV/4U4A6zalTiMnS+ XSxBh1RxFbl3CWVIgSWcHFzLrjoWM8n/348OCUtO3eu2mQiPtnzvPtOKcNvcOl17vFnwN51U +IBJ5eKDMNQR2mV4D8ad5T88tBvLUz5mQKUMiO5SzEjZJo8FRfR89rpc1K3pikDBya6r+Ukp Lik2l+JSJYPXV06Xs3XdOiu3xW6un1EwLB+WE7BI99yfkTw8dc1d3yt36Fve8xVcEfN3DqX0 QqSECw0n+iVrt9n6sTNiICFs5ytT7l0EH1FEjSJ9r2xLyTboDaumNcSTOaScDnBf2ro46H+N /5NxvTxPfBbzlZHt41wT+Riwa4kvoa9orZbykJvHWnRbkTtAbRleyHU0c5Kv6xL57lYpQrpB R7fpogEYe2EaJH/DVocBAs5deDSh/gblw7b4ekxPEintjR8+6CKUBkKMhSB4MCHwGCZ7G/xL T8dhfMr
  • Ironport-hdrordr: A9a23:I52lGKvqreJ49r1yY+wLPSDL7skDSdV00zEX/kB9WHVpm5Sj5q WTdYcgpHvJYVcqKQgdcL+7WZVoLUm3yXcx2/hyAV7AZnifhILLFuFfBOLZqlWKJ8S9zJ8/6U 4KScRD4ajLY2SS+vyU3ODXKbsdKZK8gceVbK/lvhFQcT0=
  • Ironport-sdr: b/f97Aaf5KdqUGi86QjyvAo4ziU8Bm2NDERMri8xD50iAzl37v+lKFsunxwUBAaqr4HC3lQkry Ys3jrMJ0HzkdM0KMpZhCjGyLW2Eco4Z5tTz5EcWiJy8LaWdiKxPINs+6i86BDOeu2CwZzSIAXa UZdBRoa0PUGFz+jtA37pcX/2QvutTE/HeRNT0q0gw0KZTYXppxHLwo/sqN2DdjGfE5HDGmYb9p MMAk6DIeslc1oDlYSfFLw6k7Bxp92nl56GPdt2dE7yrEEx5FVMDNSl7iapAyXbf8HSwNdDODCW Af15SUW9xan6mqxYsFYcH723
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Tue, Sep 21, 2021 at 05:43:38PM +0200, Jan Beulich wrote:
> The xen-syms and xen.efi linking steps are serialized only when the
> intermediate note.o file is necessary. Otherwise both may run in
> parallel. This in turn means that the compiler / linker invocations to
> create efi/check.o / efi/check.efi may also happen twice in parallel.
> Obviously it's a bad idea to have multiple producers of the same output
> race with one another - every once in a while one may e.g. observe
> 
> objdump: efi/check.efi: file format not recognized
> 
> We don't need this EFI related checking to occur when producing the
> intermediate symbol and relocation table objects, and we have an easy
> way of suppressing it: Simply pass in "efi-y=", overriding the
> assignments done in the Makefile and thus forcing the tool chain checks
> to be bypassed.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

> ---
> Obviously the real (but more involved) solution would be to do away with
> the recursive $(MAKE) invocations, by breaking up the long linking
> rules. Representing them instead through multiple smaller rules with
> suitable dependencies is certainly possible (and might even reduce
> redundancy).

There is an alternative to that. Linux have a script which does the kind
of step we do. So maybe doing the same and move the recipe into a script
would work too? This would allow to share the recipe between x86 and Arm
as the link phase of xen-syms is nearly identical. But to avoid calling
make from the script we would have to duplicate the recipe of %.o:%.S.
The xen.efi rules is still x86 only and I don't know whether we could
use the same script as for xen-syms.

I don't know which option would be better those two and the current
state.

Cheers,

-- 
Anthony PERARD



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.