[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 1/2] arm/efi: Use dom0less configuration when using EFI boot

  • To: Luca Fancellu <luca.fancellu@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 11 Oct 2021 10:52:08 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RZ7xgFW5MTP2F5/lY2w8Tbkjk3TQIxmeXUytyre37D4=; b=HPcyzEiEheKaUg1A4AaTo/xUemR/e8tbSNgy6bkAzds3sY8m64tDLg0LRgbbILr+OvI2lG3uYyV1wAA0U1YBCXSy0KX2h4LJvWCbJwzeJ9/LbRWV2adt0fcpGxsA4Eauo87O83ZQs8E0cXxRUw1M7BIjGQAHAfGMrWYLSdsiWIk/I/gcgN72Pnx45gU0TzBDntWLNkgpeSHgPah742nqVvRmRGrSrGihX/WXbgRAiAQ7BaFlBJP9nmiM1GYb5rW5uNEGk3mw65xeO69t52fs96SDROYuXJ2JhvaS4Gz+H7TBQ9BRqyUb01hzRGp7Ob4tLnVVG6IE8P1lkllYBJZNIw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vj1Whg3hnyECi/5HrFUnswn0B6N5/vzK/fXqNPiNxkdi7J7sXqt3TyVMIhGTUYtF8CNTwRTOxO9l71KCN+Qe0LKBiwT99kKsMsCOcJ6cKgARpduUg1El6fvMofUYLQoG0Ys26HOTBZ0MsNXIbsEtFE+fsY/EE5bbxvWrTtN6d0xwPnJ3eZG2IXbSfD8yi/IAq224uAmveLvhIKqpZE87VfbFemvXwb+hdDpGXLW4L9fy+sgjj+BJWl4sl6GCLDcP5vietBcw0LehPKJvPqRMUHwqjhhouIyE4fpIxn52hz1krQ/kkb+2T2WXaC10JsYMnXKkozLeO810Ua9M9DyUNg==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: Bertrand Marquis <bertrand.marquis@xxxxxxx>, wei.chen@xxxxxxx, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Mon, 11 Oct 2021 08:52:16 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 11.10.2021 10:50, Luca Fancellu wrote:
>> On 11 Oct 2021, at 09:11, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>> On 11.10.2021 10:03, Luca Fancellu wrote:
>>> This patch introduces the support for dom0less configuration
>>> when using UEFI boot on ARM, it permits the EFI boot to
>>> continue if no dom0 kernel is specified but at least one domU
>>> is found.
>>> Introduce the new property "xen,uefi-binary" for device tree boot
>>> module nodes that are subnode of "xen,domain" compatible nodes.
>>> The property holds a string containing the file name of the
>>> binary that shall be loaded by the uefi loader from the filesystem.
>>> Introduce a new call efi_check_dt_boot(...) called during EFI boot
>>> that checks for module to be loaded using device tree.
>>> Architectures that don't support device tree don't have to
>>> provide this function.
>>> Update efi documentation about how to start a dom0less
>>> setup using UEFI
>>> Signed-off-by: Luca Fancellu <luca.fancellu@xxxxxxx>
>>> Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
>>> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
>> Did you get indication that these are fine to retain with ...
>>> ---
>>> Changes in v5:
>>> - Removed unneeded variable initialization
>>> - Fixed comment
>>> - Fixed error message for the absence of an initial domain kernel
>>> - changed efi_arch_check_dt_boot to efi_check_dt_boot and add
>>> a stub if CONFIG_HAS_DEVICE_TREE is not declared, updated commit
>>> message about the call introduction in the EFI boot flow.
>> ... all of these changes? Every individual change may be minor enough,
>> but their sum makes me wonder. If so (or if at least one of the two
>> gets re-offered)
>> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
>> albeit preferably with ...
>>> --- a/xen/common/efi/boot.c
>>> +++ b/xen/common/efi/boot.c
>>> @@ -166,6 +166,13 @@ static void __init PrintErr(const CHAR16 *s)
>>>     StdErr->OutputString(StdErr, (CHAR16 *)s );
>>> }
>>> +static inline int __init efi_check_dt_boot(EFI_FILE_HANDLE dir_handle)
>> ... the "inline" here dropped. We don't normally add this outside of
>> headers, leaving it to the compiler to decide. In headers it's wanted
>> to avoid "defined by never used" style warnings.
> Ok I can drop it in a next serie and retain your Ack, or is it something that
> can be done on commit? 

I guess that's easy enough to do while committing. Provided of course
the two R-b get confirmed.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.