[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH v7 18/51] build: fix $(TARGET).efi creation in arch/arm


  • To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 11 Oct 2021 12:37:55 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NRU5NP45ghwB2g9kg5C3+SBfvLmDbJnrJva+gkxj/q8=; b=TNwXmVhdLgFw8rMVWNjYYyIQaMmp9Igmo/31lSPeZLN77VLt/qRDzj3ou5cTVqhMkP30OvprC2kLOsWPaJjtovnidf3y5ME6vC4SM5+O+ZGWdcFzcrltNPzErAZuM02PD39lNOHWh8GVl5XqudciGYBZONRO78oNtT7wJQrtoqgtPd3gQfAn0vS1arCZkRgh2JsPc5hYZd4g5VEzCMA/UCF/yAcSrCkcQ46vL3Km9bbYxESkdHYpcyP8B7cc/GP6STL+HT7FZY4CJ1gMxj/TgtBpJwl5sjVwdLCgFkd/dWDcBxthVFWXGwnxhwXDgxzRKaqdLlNdgb9ZFFAvlaVCNg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XegyAf1TPmLorPL7EMVKgJCBLCp9kPmLOENGi9nYBjSpWrwyqoYtB9VeJEny1oOpG2xqVPGKYl6HmICXJxzRisv+uQlQhyo9KjpzEKqnBu5eWjv4jsSVEsKMZzeMz/QXH1E2mdC4UZxA24rYGhEcuyhQ/kO9dkG7LsymtGjgK10+K2RWE1ph6v8Hs0M/DlhZv6VhGKyfYrermCgAtBbbX7LasemhcQ1Ndz0mRp8UwyPEb8L7vINe5iapzvkKw63g7LTRLTgS6SRbzdeqWrrZeycexWSkhukhumhJT5FNfrPN8etJBi3PiH4c52cCmJbHiFmY7Zdq9ve/sp0pzzZBCQ==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Mon, 11 Oct 2021 10:38:15 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 24.08.2021 12:50, Anthony PERARD wrote:
> There is no need to try to guess a relative path to the "xen.efi" file,
> we can simply use $@. Also, there's no need to use `notdir`, make
> already do that work via $(@F).
> 
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

As to the subject, I don't think "fix" is appropriate. How about "adjust"
or "simplify" or some such?

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.