[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH V5 3/3] xen/arm: Updates for extended regions support

Hi Oleksandr,

On 07/10/2021 21:29, Oleksandr wrote:
@@ -1193,8 +1215,8 @@ static int __init make_hypervisor_node(struct domain
           u64 start = ext_regions->bank[i].start;
           u64 size = ext_regions->bank[i].size;
   -        dt_dprintk("Extended region %d: %#"PRIx64"->%#"PRIx64"\n",
-                   i, start, start + size);
+        printk("Extended region %d: %#"PRIx64"->%#"PRIx64"\n",
+               i, start, start + size);
Also should be PRIpaddr
I thought I needed to change specifier only for variables of type "paddr_t",
but here "u64".
Sorry, you are right.

I added my reviewed-by and made the small typo changes on commit.

Thanks! In case if you haven't committed the patch yet, let's please wait for Julien (who asked for this follow-up) to review it.

I went through it. The change looks good to me. No need for...

In any case, I will be able to do another follow-up if needed.

... another follow-up. Thanks for sending a patch to handle my requests! :)


Julien Grall



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.