[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v7 23/51] build,include: remove arch-*/*.h public header listing from headers*.chk
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 11 Oct 2021 13:49:21 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MUuL5kdJHijeji1xEY+oeq8hIM3yywBwiLNJhiNMlew=; b=Hzv0zxhohZQ/FpzTfLz7cT7aNrU72oEB/ZuWXwzMgUGAO63pwSdd8gng7ePS9aC30G2P+SKNz7dSZWT42w6LgpqcmL3RSCv3VSJhNeEz393gMVQLWDuKmGR/BgxMXkcnmSwEbwaVpmjMKi9v09SLx1w72ldcTE2GO4IVYR9SNT4z37DDJ0tFCcEZ8Xz5f15VHkv+6sMBFBpM0Q+bGNbXrlzXzwy9KaltWS+EAV9ABp3cB18eE7xlKlLwiXQzttoNz4oC8WO4EFuk3dV2tN38C08jX6XFPeJZ72s77yityVVeBuWt1LLHaJNsdyuZesXmTddzZZnOPoed1SVchJv5Fw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VesjsPIWIy+805g4gzJRBB6wHLeBhMmou7fPOvQA6ZFKwWOYgUpwoyrIqwgNoP0+tNsH5B2smxfth6rbFkLAoGJ5dpELPkiV76GxttWwbANcXZT82TyhbjURypHtyTykO2SFh19ZRowShsunRH5xY6r3xKXIxlpu/39pBNwYevD8JK9OkBXCSPuTV+2Lnyyts/8at3MmyWFI5cw8JQn003CNs4feechz0lwXnuLrw0YeOSBuGqnkK8QMQupcuF2Qtu+GTDrGiHWryi/0VABtf9ABIlMdv+C5mulUWw854cnUqj8mZwW7raBGL4cgYEsks80UBqph5Ix6y1w5k3gKjw==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 11 Oct 2021 11:49:29 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24.08.2021 12:50, Anthony PERARD wrote:
> $(public-y) contains "public/arch-%" but when used by
> $(PUBLIC_HEADERS) $(public-y) is filtered-out by the pattern
> "public/arch-%". So $(public-y) content is never used.
It has been this way from its very introduction, and iirc $(public-y) was
meant to be an abstract construct to which other pieces could get added
in principle. I'm having a slight preference to keeping things as they
are, unless you tell me that this is getting in the way of anything. And
to be clear there as well - if there are no other reasons than pure
cleanup, and if somebody else approved of the removal, I wouldn't object.
Jan
> --- a/xen/include/Makefile
> +++ b/xen/include/Makefile
> @@ -39,9 +39,6 @@ cppflags-$(CONFIG_X86) += -m32
>
> endif
>
> -public-$(CONFIG_X86) := $(wildcard public/arch-x86/*.h public/arch-x86/*/*.h)
> -public-$(CONFIG_ARM) := $(wildcard public/arch-arm/*.h public/arch-arm/*/*.h)
> -
> .PHONY: all
> all: $(headers-y)
>
> @@ -81,7 +78,7 @@ ifeq ($(XEN_TARGET_ARCH),$(XEN_COMPILE_ARCH))
>
> all: headers.chk headers99.chk headers++.chk
>
> -PUBLIC_HEADERS := $(filter-out public/arch-% public/dom0_ops.h, $(wildcard
> public/*.h public/*/*.h) $(public-y))
> +PUBLIC_HEADERS := $(filter-out public/arch-% public/dom0_ops.h, $(wildcard
> public/*.h public/*/*.h))
>
> PUBLIC_C99_HEADERS := public/io/9pfs.h public/io/pvcalls.h
> PUBLIC_ANSI_HEADERS := $(filter-out public/%ctl.h public/xsm/%
> public/%hvm/save.h $(PUBLIC_C99_HEADERS), $(PUBLIC_HEADERS))
>
|
