[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 09/11] xen/arm: Transitional change to build HAS_VPCI on ARM.


  • To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
  • Date: Mon, 11 Oct 2021 12:15:12 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zEKwnfBc4cXiX2oHKPeKys6AniPzg4+TgZzBCWQxMO8=; b=I7btnCCABF0J7vkwk6lrEZx2cZOYa3WlFeCDscKBDN0J7qQthEpsn43IvPp4pgtuRv21QAzcht90JEJ6LyCScZMdUorHpeLdDTCMc5rVEYyZ7HbWY6f/ME7HfuavEaKwDtEpsP8e9YtkOMMEG19AstLOHp0NjFrnue1LzjqQIMcFXpMVLaD1n8KJ+wW9VnOvJij9QUv+lLWGMaDBIn0aBvdU4xhqEsk+kQNo34bv/yGgBn8N160QH8Jy2ltf4p6CJJexseCPiHUb4MAD1paaMbqHvW7UFcealLkDrI7a7xcjntnmv44UriLHe88eUs+ObVpKOY1yRIw5f5dcijmr/g==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ccqq3s63xEc6bXBMTd0EyncF8D5R3358UyfrDQgIJNSoxa0Bj5xvfmadbuovAqHjcOh8YOB7fSoRgICGWViztfn/nScpCd9jB1Ctd7iZ2AfCBwxADNYgFrTsijIEuBSlmbuXGJfpr2MuRiEExfFQzAg5dxW/JO41z6rDeejQfWlv1zkyV5FJOzoMnieZoRVJRD74HiSdmXkbsIRGvxi980tDwMSZwDx6TFwINLiIuQchQaDBuWjx0k3jXVfAFMQiJJSq0e6rdcgT6Okg8iKFgRB4PfaLJnu357c7j9pNRafDx0QNN2+l1FrvCjbq6RJoJcHeGQ95hsPahcaDJPDtBA==
  • Authentication-results-original: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;
  • Cc: Rahul Singh <Rahul.Singh@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andre Przywara <Andre.Przywara@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Mon, 11 Oct 2021 12:15:32 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHXutl6IKP3e9kgZEyzzoGYw0qm9avNtJ8AgAAI9IA=
  • Thread-topic: [PATCH v5 09/11] xen/arm: Transitional change to build HAS_VPCI on ARM.

Hi Roger,

> On 11 Oct 2021, at 12:43, Roger Pau Monné <roger.pau@xxxxxxxxxx> wrote:
> 
> On Wed, Oct 06, 2021 at 06:40:35PM +0100, Rahul Singh wrote:
>> This patch will be reverted once we add support for VPCI MSI/MSIX
>> support on ARM.
>> 
>> Signed-off-by: Rahul Singh <rahul.singh@xxxxxxx>
>> Acked-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
>> Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
> 
> Reviewed-by: Roger Pau Monné <rogewr.pau@xxxxxxxxxx>

Thanks

> 
>> ---
>> Change in v5: none
>> Change in v4:
>> - Added Acked-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
>> - Added Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
>> Change in v3: none
>> Change in v2: Patch introduced in v2
>> ---
>> ---
>> xen/drivers/vpci/Makefile | 3 ++-
>> xen/drivers/vpci/header.c | 2 ++
>> xen/include/asm-arm/pci.h | 8 ++++++++
>> 3 files changed, 12 insertions(+), 1 deletion(-)
>> 
>> diff --git a/xen/drivers/vpci/Makefile b/xen/drivers/vpci/Makefile
>> index 55d1bdfda0..1a1413b93e 100644
>> --- a/xen/drivers/vpci/Makefile
>> +++ b/xen/drivers/vpci/Makefile
>> @@ -1 +1,2 @@
>> -obj-y += vpci.o header.o msi.o msix.o
>> +obj-y += vpci.o header.o
>> +obj-$(CONFIG_HAS_PCI_MSI) += msi.o msix.o
>> diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
>> index ba9a036202..f8cd55e7c0 100644
>> --- a/xen/drivers/vpci/header.c
>> +++ b/xen/drivers/vpci/header.c
>> @@ -96,8 +96,10 @@ static void modify_decoding(const struct pci_dev *pdev, 
>> uint16_t cmd,
>>      * FIXME: punching holes after the p2m has been set up might be racy for
>>      * DomU usage, needs to be revisited.
>>      */
>> +#ifdef CONFIG_HAS_PCI_MSI
>>     if ( map && !rom_only && vpci_make_msix_hole(pdev) )
>>         return;
>> +#endif
> 
> FWIW, I would also be fine with providing a dummy inline function for
> vpci_make_msix_hole when !CONFIG_HAS_PCI_MSI, but I assume this is a
> temporary workaround until MSI is implemented for Arm.

Yes this is temporary and MSI support will be added on Arm.

Regards
Bertrand

> 
> Thanks, Roger.


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.