Re: [PATCH v5 09/11] xen/arm: Transitional change to build HAS_VPCI on ARM.

[Bertrand Marquis <Bertrand.Marquis@xxxxxxx>]

Hi Roger,

> On 11 Oct 2021, at 12:43, Roger Pau Monné <roger.pau@xxxxxxxxxx> wrote:
> 
> On Wed, Oct 06, 2021 at 06:40:35PM +0100, Rahul Singh wrote:
>> This patch will be reverted once we add support for VPCI MSI/MSIX
>> support on ARM.
>> 
>> Signed-off-by: Rahul Singh <rahul.singh@xxxxxxx>
>> Acked-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
>> Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
> 
> Reviewed-by: Roger Pau Monné <rogewr.pau@xxxxxxxxxx>

Thanks

> 
>> ---
>> Change in v5: none
>> Change in v4:
>> - Added Acked-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
>> - Added Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
>> Change in v3: none
>> Change in v2: Patch introduced in v2
>> ---
>> ---
>> xen/drivers/vpci/Makefile | 3 ++-
>> xen/drivers/vpci/header.c | 2 ++
>> xen/include/asm-arm/pci.h | 8 ++++++++
>> 3 files changed, 12 insertions(+), 1 deletion(-)
>> 
>> diff --git a/xen/drivers/vpci/Makefile b/xen/drivers/vpci/Makefile
>> index 55d1bdfda0..1a1413b93e 100644
>> --- a/xen/drivers/vpci/Makefile
>> +++ b/xen/drivers/vpci/Makefile
>> @@ -1 +1,2 @@
>> -obj-y += vpci.o header.o msi.o msix.o
>> +obj-y += vpci.o header.o
>> +obj-$(CONFIG_HAS_PCI_MSI) += msi.o msix.o
>> diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
>> index ba9a036202..f8cd55e7c0 100644
>> --- a/xen/drivers/vpci/header.c
>> +++ b/xen/drivers/vpci/header.c
>> @@ -96,8 +96,10 @@ static void modify_decoding(const struct pci_dev *pdev, 
>> uint16_t cmd,
>>      * FIXME: punching holes after the p2m has been set up might be racy for
>>      * DomU usage, needs to be revisited.
>>      */
>> +#ifdef CONFIG_HAS_PCI_MSI
>>     if ( map && !rom_only && vpci_make_msix_hole(pdev) )
>>         return;
>> +#endif
> 
> FWIW, I would also be fine with providing a dummy inline function for
> vpci_make_msix_hole when !CONFIG_HAS_PCI_MSI, but I assume this is a
> temporary workaround until MSI is implemented for Arm.

Yes this is temporary and MSI support will be added on Arm.

Regards
Bertrand

> 
> Thanks, Roger.