[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] libxl: CODING_STYLE: Explicitly deprecate #ifdef
- To: Ian Jackson <iwj@xxxxxxxxxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Tue, 12 Oct 2021 16:02:52 +0100
- Authentication-results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
- Delivery-date: Tue, 12 Oct 2021 15:04:31 +0000
- Ironport-data: A9a23:26jMqqykVN5aGP9BwUl6t+fSwSrEfRIJ4+MujC+fZmUNrF6WrkVRx jcaWWmDMq2IZzT2fN92O4my80IFvp/Vz4BgTgdv+SAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAsLeNYYH1500s6w7dj2tcAbeWRWGthh /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt/9x8 dJcqsShdV0SB6mVktUNTCtBTj4raMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr 6ZBbmlQMFbT3Ipaw5riIgVors0lMMnsOpJZonx6xCvVJf0nXYrCU+PB4towMDIY250VTKuEP 5txhTxHXAT/fhZCZnAsUY8QsKSGpkanWhNkkQfAzUYwyzeKl1EguFT3C/LKfvSaSMMTmVyXz krE8H7+GQoyL8GExHyO9XfEru7QnwvrVYQKDrq6+/V2xlqJyQQ7GBAQEFe2v/S9okq/QM5Eb VwZ/DI0qqo//1DtScPyNyBUu1bd4ERaAYAJVbRntkfdkcI4/jp1GEArTgdGecN+pfNsfgUuj 1W4j8zbHGFw5ej9pW2myp+Yqja7OC4wJGAEZDMZQQZt3+QPsL3fnTqUEY49SP/dYsndXGiqm WjT/XdWa6A71JZTj82GEUb7byVAT3QjZjU+4RnLRSqb5wd9aZ/Ni2eAuAWDs6gowGp0SDC8U Jk4dyq2sL5m4XKlznXlrAAx8FeBvajt3Nr02w8HInXZ327xk0NPhKgJiN2EGG9nM9wfZRjia 1LJtAVa6fd7ZSXxNv4oPNLhVZp3kcAM8OgJsNiOMLKihbArJWe6ENxGPxbMjwgBbmB9+U3AB XtrWZn1VitLYUiW5DG3W/0cwdcWKtMWngvuqWTA503/i9K2PSfNIZ9caQfmRr1pvcus/VSOm /4CZpTi9vmqeLCnCsUh2dVIdg5iwLlSLc2elvG7gcbaelA4Rzp7V6OIqV7jEqQ895loei7z1 inVcidlJJDX3CKXQelTQnw8Or7pQ7hlqnc3YX4lMVqygiBxaoez9qYPMZAweOB/puBkyPd1S dgDetmBXasTGmiWpWxFYMmvtpFmeTSqmRmKY3ivbg8gcsMyXAfO4NLlIFfirXFcEiqtuMIii LS8zQeHE4EbTgFvAZ+OOvKixl+8p1YHn+d2UxeaK9VfYhy0ooNrNzbwnrk8JMRVcUfPwT6T1 gC3BxYEpLaS/99poYeR3a3d9tWnCepzGEZeDlL317fuOHmI5HenzK9BTP2MIWLXWlTr9fjwf u5S1fz9bqEKxQ4Yr4pmHr935qsi/N+z9aRCxwFpEXiXPVSmDrRsfiuP0cVV7/Afw7ZYvU29W 16V+8kcMrKMYZu3HFkULQsjT+KCyfBLxWWCsaVreB33tH1t4b6KcUROJB3d2iVSIYx8PJ4h3 ep86tUd7Bayi0ZyP9uL5syOG79g8pDUv30bi6wn
- Ironport-hdrordr: A9a23:ThauEqv/RJPa+3J86J8r55ah7skDdNV00zEX/kB9WHVpmszxra GTddAgpHjJYVcqKRUdcL+7VJVoLUmyyXcx2/h2AV7AZniChILLFvAA0WKK+VSJcEeSygce79 YDT0EXMqyIMbEQt6bHCWeDfeod/A==
- Ironport-sdr: OuRgQDMzgJy/ub8hNyUZm9KJCEgKY1w+oyVWRSbbZlDqB093nVL0c4WxP77HRnTXHZRJQtlHiI B1Nj9uVb2+HYmkuxFLaOy1nxZ5h1t+mqbFpYrClRUvNX1ylqNMqdxES3pIHl9LOzLe7ey3392L A3ujECqNFn4c5J9bcLoo2um0uTTv/DmsULNzvClq8G9cfd8jr+7Y7lnYy/OXVtsStrnnsrbwVn cmfA/L9G2c9Pgj1HupIwgCxPE5bXUrHqVcVTet4PIuUyGlpPLL9EuafwY+Sp+YHp6lGr7GQMgR HqWp+0awIdsQMexm10DblFrL
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Oct 12, 2021 at 03:52:26PM +0100, Ian Jackson wrote:
> We don't use ifdefs in the main code. Actually document this.
>
> Signed-off-by: Ian Jackson <iwj@xxxxxxxxxxxxxx>
> ---
> tools/libs/light/CODING_STYLE | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/tools/libs/light/CODING_STYLE b/tools/libs/light/CODING_STYLE
> index 3d572f6925..c2342c9d3b 100644
> --- a/tools/libs/light/CODING_STYLE
> +++ b/tools/libs/light/CODING_STYLE
> @@ -121,6 +121,16 @@ permitted exceptions to the usual libxl code formatting
> rules.
>
>
>
> +ARCHITECTURE-SPECIFIC CODE, CONDITIONAL COMPILATION
> +---------------------------------------------------
> +
> +Architecture-specific code should be isolated in libxl_<arch>.c,
> +with a function call interface, whereever possible.
s/whereever/wherever/ ?
> +
> +#ifdefs should be avoided, and in any case not interspersed through
> +the primary functional code.
> +
> +
> IDEMPOTENT DATA STRUCTURE CONSTRUCTION/DESTRUCTION
> --------------------------------------------------
>
Sounds good,
Acked-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
--
Anthony PERARD
|
