[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH V6 2/2] libxl/arm: Add handling of extended regions for DomU

On 12.10.21 18:32, Ian Jackson wrote:

Hi Ian

Oleksandr writes ("Re: [PATCH V6 2/2] libxl/arm: Add handling of extended regions 
for DomU"):
On 11.10.21 20:48, Oleksandr Tyshchenko wrote:
Hi Ian, Stefano
+        LOG(DEBUG, "Extended region %u: %#"PRIx64"->%#"PRIx64"\n",
If this appears to be the last version, may I please ask to remove
unneeded "\n" in the message above while committing? Thank you.
I think Stefano will be committing this but: personally I don't like
the "edit on commit" workflow.  Committers are already a bottleneck
and it is easy to make uncontrolled mistakes.  I find the most
convenient workflow to be to acquire a git branch from somewhere and
commit that, so if you provide a git branch with the acks folded in
and this kind of minor fix included, that would be ideal.  Ie,
git-request-merge format or something like it.

Yes, I will provide a git branch later on today.



Oleksandr Tyshchenko



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.