[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM.

  • To: Ian Jackson <iwj@xxxxxxxxxxxxxx>
  • From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
  • Date: Tue, 12 Oct 2021 16:15:20 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YYDm+x1uHHoe95VdJZCKrnBh2rXyUDEoWYPYidSuYM8=; b=Zb//hHJ06cnCk8LmN/qWROiq2yPn6/48tKVZYB0XyXXAQO6fg8X16qTBrBMd+uleO6pGpDloFMJIz10Rwv6ymZeG0o1k832SKIaqYM8nJjlB3laotrcpKFcdUBgeWFX21RySTlQlip6jiDiPd8jhMrhZbWsPtYZ6pTWej6sDn6R661HkZ/Hhp2njlfEvZWCkHFYBN9tjh4xo6oivqxmLrb7vi9PADH+O62uza7sSSOH2L8bA1fQiT0gTz2HqzzkFOtyih+k/r+8qg/mn237L76ST5rmAV91EasvhrBup0weQrAK9cgMPM3xmIhYgZVjolQN8sDX4tg00H2NDzrWjgA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gBa4n+8ccl5cJbXq56rnnfP78VvcShGQASe5r5Kj981+cyWjYBI/naiLjKi5ECZNMOXcKqSz1UvP6tPft0pOzeWMsQbuVdQv1p1zKUddGfiClbB+ZUa4kDfiQU/v1uRgdQYb35+O4cJBg66p4r+fWMF0mZPvIUsiLgNccENAQQYqxgYu5n6Ahv7ev0lQnp2akdr0ls49zKawyY+VV929/ZP/oZqHeB0vplbNHnDfRg7wV65hK+1HkZNAL3qHxYp5mvGBnXF79MW1w1+4AbgeEXT2sOgttDKwNLk+gP6zFj/hy94vHexgISiIUlbCJqm9wVazS2kEd8ImAuXAIPEasQ==
  • Authentication-results-original: xenproject.org; dkim=none (message not signed) header.d=none;xenproject.org; dmarc=none action=none header.from=arm.com;
  • Cc: Jan Beulich <jbeulich@xxxxxxxx>, Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>, Rahul Singh <Rahul.Singh@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andre Przywara <Andre.Przywara@xxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Tue, 12 Oct 2021 16:15:53 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: xenproject.org; dkim=none (message not signed) header.d=none;xenproject.org; dmarc=none action=none header.from=arm.com;
  • Thread-topic: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM.

Hi Ian,

> On 12 Oct 2021, at 15:53, Ian Jackson <iwj@xxxxxxxxxxxxxx> wrote:
> Bertrand Marquis writes ("Re: [PATCH v5 01/11] xen/arm: 
> xc_domain_ioport_permission(..) not supported on ARM."):
>> So there is no comment remaining on this patch ?
> I have been following this thread.  I think I have a notion of why
> this is needed but I'm not 100% clear on it.  The commit message says
> this:
>> ARM architecture does not implement I/O ports. Ignore this call on ARM
>> to avoid the overhead of making a hypercall just for Xen to return
> which implies it's a performance improvement.  But the change also
> suppresses an error return, so this commit message is false.  I think
> that the thread has concluded something different, but it should be
> explained in the commit message.  The purpose of a commit message is
> precisely to capture the kind of considerations and discussion that
> occurred in this thread.

I can add something in the commit message about the fact that we improve
performance and prevent to do a call that is and will not be supported in Xen.

> If the overall outcome implied by this patch is correct (as I *think*
> the thread has concluded) then I don't think the #ifdefery is
> appropriate.  This should be done with a new arch-specific function in
> libxl_x86.c and libxl_arm.c.  I'm not sure precisely what that
> function should be called, but maybe something like
>  libxl_ioports_supported
> ?
> I see that the fact that we avoid #ifdefs wasn't documented in
> CODING_STYLE, so I have sent a patch to add that.  Sorry about that.

I saw your change in CODING_STYLE and I understand the request.
I will try to see if we can handle this change before the feature freeze.


> Thanks,
> Ian.



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.