[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 08/11] xen/arm: Enable the existing x86 virtual PCI support for ARM.

  • To: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 13 Oct 2021 14:21:22 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/syMxzoUxIqbyCmc8IhtwqOjBQKNvck9LFDbtkJdXQA=; b=LB5XJeHTNp37c8Lt8Ckhk4W0J4yJ6frmp/uiNell0rkuvaSg7+FDvjz5VCwl8MzQ4BByUmfPyc+QeTcVjal1g0Kc5/lgEdCEX4T9Kv2/fIz3F9oQjGB4Ll4QB8TEyi8PNNQOuSGFWQ7NspUpzhv5aXkw0tGjC48gvrKqAhs6LddscFf3JDXdcT5rSP6aHmVEM6Ft0ywgdr0QLaKTPaleVXeRaWs99L73iUMMkv0OZNNERFJN4mSjW4OPX9YF80mBHCb6hRnXfLyAXVA3EE0VvYDMx+p56jIR5c+mDdlKKnA9ZKeC1gxnaSZd8fmW7JEAqa1ufuy862e96WDfjiEx5g==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Nv4w+qSi7g2ktbymsPj29PlrbphbKpMjhN8KE8lfdLzwPHjwu4o3OUVY3GRWU/PfLI/cjbyq/834wznP7ju4a+zk12jENeQhUkFmSFbooZR/quSxC0K0EcMOBZsjgqH0vrO+0UufCGjvRUDjNZjYL9rbH2cIcb/9JAs/QL5zOHLbTFTyaKbn6kYu08jf4Jkw3QQ/2KtLafchXwI/glV/QKJmPj8X5HA9Rx2Nsn6Vl+TctCacASDagXhr9wI3fQ2KadrCk/SSCE/4E6EtZ+8jNNGZvb8OxKLccov/ql+qRjTctPaot7lYbsGcK8RKYMxBoEbh3nv0AyIOOGhwea1k6Q==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Rahul Singh <Rahul.Singh@xxxxxxx>, Andre Przywara <Andre.Przywara@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Paul Durrant <paul@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Wed, 13 Oct 2021 12:21:32 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 13.10.2021 12:02, Bertrand Marquis wrote:
>> On 13 Oct 2021, at 07:10, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>> On 12.10.2021 23:37, Stefano Stabellini wrote:
>>> Good point about MSIs not being setup before the traps. We should remove
>>> the call to pci_cleanup_msi() in the error path then.
>> Your reply makes me fear you didn't pay enough attention to the "partial"
>> in my earlier reply. The traps for the various registers can't all be set
>> up atomically, so there may be a transient period where enough traps are
>> already in place for a cunning guest to arrange for setup. Unless, as
>> said, there are further setup steps needed before a guest could succeed
>> in doing so.
>> But even if partial trap setup alone was sufficient, I think the cleaning
>> up of MSI then might still better go on the error path there than on that
>> of pci_add_device().
> I think I should put the msi_cleanup in the exit path if pdev is not null but
> we got a non null ret (in an else if ( pdev ) ).
> This would cover all exit paths, especially as I will move the add_handler
> before the iommu init.
> Would that be ok for everyone ?

Sounds reasonable at the first glance.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.