[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v7 24/51] build: prepare to always invoke $(MAKE) from xen/, use $(obj)
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 13 Oct 2021 14:35:12 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z0H9+WKjmlmsm9ExH6rOGGW7jztCS6kGe4pQCjtAIGc=; b=UYLLNUzCeXmzrMvx+iT/615xoSuv2jw7tA28Q4fZfsptPvZHLNPkwTfYsj6xV4I05aV+S4VgIU+usVm8XrraufdDbGgsBFm48J9GWW/aOV8jzUEd8TuFG3RsNEfBiVpHqchMpAIomt4qKay8VBm8Yno/VDZBwlGF7RMSCNE7an+BG4kTaRy70unPBAgLegPmybIAlQgiugpXZH/ygcuMNpIr02KSWgl1J/9BeYr0XHYgM1x5ADdFT+Awp+csH0UZF7gK+Ulzrwy8edtWHEf9oY92spgJ0yk4LwcpuMvgCnGiClc14+d9LOjryigtayOY6xfOJIHNLL2YIIjHYL6QJQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cAL4Vg6pg1idZ0+dQEcpJqenNPYJ2nY6xKzUy9JkQsAIihAf6b/hc1ILa0J5tRgKyBbnz1DhNV2nhmkg3zxyd88cKN/KtJyPiDPnFucON6eEh8pMEcgQcsDJeLk3G4/2DQPjYgNIoyfCRUqGG03zN+J4FM41VVN10R1HeWgJAoOAhXDs0EMDHGPVuxuoagb4p1JCCBQ/a6AShdkz2ngUDINoEQILbCq4B1J5gtz3z4Vbc1iDVT+1z+LqU97M1BGFfqEvmn3Kv+n1AAfhxGVxtqC5tlLErT8i3DnTXWi5UlksdkxQCKzqNFwyGqCVkyikIKT52qIy4/fQy79VqoL5qA==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 13 Oct 2021 12:35:25 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 13.10.2021 12:57, Anthony PERARD wrote:
> On Mon, Oct 11, 2021 at 02:39:26PM +0200, Jan Beulich wrote:
>> On 24.08.2021 12:50, Anthony PERARD wrote:
>>> @@ -222,14 +222,14 @@ $(TARGET).efi: FORCE
>>> endif
>>>
>>> # These should already have been rebuilt when building the prerequisite of
>>> "prelink.o"
>>> -efi/buildid.o efi/relocs-dummy.o: ;
>>> +$(obj)/efi/buildid.o $(obj)/efi/relocs-dummy.o: ;
>>>
>>> .PHONY: include
>>> include: $(BASEDIR)/arch/x86/include/asm/asm-macros.h
>>>
>>> -asm-macros.i: CFLAGS-y += -D__ASSEMBLY__ -P
>>> +$(obj)/asm-macros.i: CFLAGS-y += -D__ASSEMBLY__ -P
>>>
>>> -$(BASEDIR)/arch/x86/include/asm/asm-macros.h: asm-macros.i Makefile
>>> +$(BASEDIR)/arch/x86/include/asm/asm-macros.h: $(obj)/asm-macros.i
>>> $(src)/Makefile
>>
>> Isn't this $(obj)/include/asm/asm-macros.h ? And in general doesn't
>> use of $(BASEDIR) need to go away then, e.g. ...
>
> I've limited this patch to add $(obj)/ and $(src)/ were needed, I think.
>
> And yes, BASEDIR will need to go away.
And replacing it here while you're touching the line anyway is not an
option?
>>> --- a/xen/scripts/Makefile.clean
>>> +++ b/xen/scripts/Makefile.clean
>>> @@ -3,11 +3,14 @@
>>> # Cleaning up
>>> #
>>> ==========================================================================
>>>
>>> +obj := .
>>> +src := $(obj)
>>
>> This repeats what is also getting added to Rules.mk. To prevent
>> the two going out of sync, wouldn't they better live in a central
>> place (e.g. scripts/defs.mk)?
>
> It looks like they are the same but they are not, it doesn't matter if
> they go out of sync, and they actually do in my patch series.
How can them going out of sync be correct?
Jan
|
