[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v7 51/51] build: add %.E targets
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 13 Oct 2021 17:48:22 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tDu+Xsy6PHEycPNm1o5bLYDgOz/PTFwtVGm4wTu1riY=; b=grjuJ5r83ITNGrSZHqJV0dAUhtTrLs9WVXUpoPcyZYcregl3Z9j94+XInQ6s/iJxF7hdTore5IHHaQu1jbHdOj6ePSjJb9eSEK2FACHkpmircf/n8rzLHnyFZ7y/ZVsVO5cPbaVJHO8ULdL/jmlzp4n2HXzkfUnatAKYAT7lYxlOJnevS2urqXD6a3Hr/HnU05uKSazM9l9spWpTJRmGZ6PmcwOTRjWhtZAXcESP+ngrnwlW/szbwN3jReVR+BUUIBYb6qTuXpdB2Nvupy+h0wrVdlJztby74mjLcW2nuANb4J6wwNMHGEX0IaRO4vvlTdgkNVEXNcquuis7lGCCGA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UxOlNCnDISd0g1n4N6nMvESiHdceBMvBRM9F5TP5cOa9l8dMbJKxdo63TY9tve9iTVhIWCGjImYcZU9ZcakwraWIA3RCAz3DXBTjj2LFJ61trOQfAi+05C6uvzHQOcR3AsT8xvmaaRVEqzRA2SNxhqqCMkdBq7l49TH6F2RPxreaZU6eI8hJ+YRp41u42JJyWBhmjzc9KtrytnqT7BxiE9GsB/1XTDFRGkJ0TVOIp++MA7/bYJpbeU5aw4suhNaD1gIEvurUH5hAlVuPCfCEF5tCZbt3MJNXgWtT3n12KqTqmbzSiDWksppgRJ83ZMXvkApNafhuOsxkAYzSJE+Njw==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 13 Oct 2021 15:48:35 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24.08.2021 12:50, Anthony PERARD wrote:
> I guess it's easier to remember that %.E does "$(CC) -E" or "$(CPP)".
I've never seen any *.E. I'm puzzled (and hence have reservations, but
then again don't care enough to object).
> --- a/xen/Rules.mk
> +++ b/xen/Rules.mk
> @@ -289,6 +289,11 @@ $(obj)/%.s: $(src)/%.c FORCE
> $(obj)/%.s: $(src)/%.S FORCE
> $(call if_changed_dep,cpp_s_S)
>
> +$(obj)/%.E: $(src)/%.c FORCE
> + $(call if_changed_dep,cpp_i_c)
> +$(obj)/%.E: $(src)/%.S FORCE
> + $(call if_changed_dep,cpp_s_S)
It's kind of sad in this case that you can't fold these with the %.i
rules.
Besides the changes you make, don't you also need to adjust some
"clean" rule?
Jan
|
