[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH v7 40/51] build: fix dependencies in arch/x86/boot


  • To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 14 Oct 2021 10:08:42 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GW9Cbua5oZ362cbCXIdYE06fuKD9FywCuCQTgiWmguA=; b=a9S5hX7rs3RxLJGyAxcswMP2qM/+1KyvZUrh+sYq8rKINBSNhPmazkl9YsGsflOFqK4dzir//MXaMWD5y5TXmureEOdZgQwBJfCg+TcadJtn3AjkBO4+sIYtOZAR9Ajmv6VJuuwvwEn7tFAM4t1VrTlmQqm0nnzqyJCEWI0DEUn93C7tSAYU/v8s7QEvUsQ8V2x1S3Tm1feZL2hg1nudheAWLJHP+p2a1q3m8PA3GrGdkJ9GTUyWx2Wd6plw0L6xzYTRV3mNmQ5XFLA5FIWuGkvxbOygIXyQ6+lEjTK+5cErJnzNrMCv+5eRMg/xlGl6fg9plw+AK2fEQUbQkXIvqg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Cg4C/voBt2yikgn2Ex4SnHyRznAwb6QktcgP3wlFQimyYKPpBCWmzp4ON7Q2nD9u5m3lw251Qb1QzSCFf8QAcdA9wyj8y8bbhWu6I/amUVs8RthF6SoicNMG0xuACjU/PD9SwuyF1dxe/eS/q+9ic+fA0/FZ6T9mLCT3dth5c7TIgjnjVKXZtAwN+q1RrcTGGu0PF+BvoiuVrP17rbfMx1HlbawWqfro598mt+xLEcJV5U1SosnXc3fRffDHadNbXkXcCpDdyH4R+TMHnw3YOyDSFyWLEU3k9R+m4vP7ErvlZoNHQumrCzjpd4wp6vsUb2Q/VQ3y+5IuygxVILGmEA==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Thu, 14 Oct 2021 08:08:56 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 24.08.2021 12:50, Anthony PERARD wrote:
> Temporary fix the list of headers that cmdline.c and reloc.c depends
> on, until the next time the list is out of sync again.
> 
> Also, add the linker script to the list.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Afaict this is independent of all earlier patches, so I'll make an
attempt at committing this soon.

> --- a/xen/arch/x86/boot/Makefile
> +++ b/xen/arch/x86/boot/Makefile
> @@ -2,19 +2,22 @@ obj-bin-y += head.o
>  
>  DEFS_H_DEPS = $(BASEDIR)/$(src)/defs.h $(BASEDIR)/include/xen/stdbool.h
>  
> -CMDLINE_DEPS = $(DEFS_H_DEPS) $(BASEDIR)/$(src)/video.h
> +CMDLINE_DEPS = $(DEFS_H_DEPS) $(BASEDIR)/$(src)/video.h \
> +            $(BASEDIR)/include/xen/kconfig.h \
> +            $(BASEDIR)/include/generated/autoconf.h

Especially with this now needed in two places, I think down the road
(unless we'll get dependency tracking automated here, which a part of
your description suggests is not going to happen soon) we want

kconfig.h := $(BASEDIR)/include/xen/kconfig.h \
             $(BASEDIR)/include/generated/autoconf.h

and then similarly ...

>  RELOC_DEPS = $(DEFS_H_DEPS) \
>            $(BASEDIR)/include/generated/autoconf.h \
>            $(BASEDIR)/include/xen/kconfig.h \
>            $(BASEDIR)/include/xen/multiboot.h \
>            $(BASEDIR)/include/xen/multiboot2.h \
> +          $(BASEDIR)/include/xen/const.h \

multiboot.h := $(BASEDIR)/include/xen/multiboot.h \
               $(BASEDIR)/include/xen/const.h \

(and by implication I think DEFS_H_DEPS would better be renamed to
deps.h as well).

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.