[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v7 43/51] build: replace $(BASEDIR) by $(objtree)
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 14 Oct 2021 11:21:32 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z3bck/rJCyy0kh/AKYB/Mhw0+Rt313zEVP2i6+Gm0bM=; b=oS2flVuBhuFKfSa5iyY43tzkdWDBUWfEA537hlrxbZCbDJGhn9hUdgkNyF2jMP5FxQxrRIE6km8JoBnqN9BfSOmLWQofBUkzfvZtKKNJpRaR6iI8rxILwyRNBDu8f34ApctZzlnlgc9Bn6q3lQ6qEtT7XdxEFCqHnfCryWoaAPJtkVeAfF5TflSYuQCjm1pnoKfCnDeHUPr46VkXhKZ35E/c+ZCC1qJL7mGC1LM42n280xHeROXEg9BHPWeKa6G8LU1pA3MW7MWR68wO+TqqUXMyCl0TMgOmHgYQ3dXkljNW69euuAgYT0RHQlMuyDWAh9RJgCPVrrglrqyUchfM7g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=icq/JSjqQCzvJ5DQYVHXJhu+jOnoTXBVmpljMQwqmHyLDEKIMdL51fe+PIw7TmiSamFmH9HSBuuhnjz0yDV326+kEGrdH9BdJGxNtAMIMBzA5/Qewp4BqjjJolpEq+3LFlnPtgJ/xxSojb80Zwv0MNJS40lJf6pLQbYmzsldpmWZQNalIqC1zEUaLLvKIsd2Dbf+/9foMk6APfpjDxuToc1Kd3u1Vpx8MeIDYDNngfeaPO5g/SKoS/T+DOor2RFvzib7x3zn0oX1OwBADGgGwzYyELl4y5az3iCXo6nl2GMwmg6/MFSZ70lwgVibqcDK4/3y9e5UuYqIQnyf78GHCA==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>, Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 14 Oct 2021 09:21:45 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24.08.2021 12:50, Anthony PERARD wrote:
> We need to differentiate between source files and generated/built
> files. We will be replacing $(BASEDIR) by $(objtree) for files that
> are generated, and $(abs_objtree) in cases where an absolute path is
> necessary.
>
> The "clean" target is still changing to the subdir been cleaned, to
> remove file in the root we need to use $(abs_objtree).
Vaguely related more general question: How useful is "clean" for an
out-of-tree build? That ought to effectively remove the entire build
tree, which may not be overly sensible to do via "make clean-xen",
but instead simply "rm -rf ...".
> @@ -117,4 +117,4 @@ $(obj)/dtb.o: $(patsubst "%",%,$(CONFIG_DTB_FILE))
> .PHONY: clean
> clean::
> rm -f $(obj)/xen.lds
> - rm -f $(BASEDIR)/.xen-syms.[0-9]*
> + rm -f $(abs_objtree)/.xen-syms.[0-9]*
This part is common - would it make sense to move to xen/Makefile, thus
- aiui - eliminating the need for using $(abs_objtree) here / there?
Jan
|
