[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v7 45/51] build: rework cloc recipe
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 14 Oct 2021 11:33:16 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yfAWO0mgGXRLRjSdL+G/R1lOhK/9ZNYPNz6qqMV3IHk=; b=V6S480btlv1koPQSSJq16EO6Q9crTc6OWyySRVxrVx1QoGhF+k5/SX1PAu5+IUpakXiaEiNKn00ppneOiHSCH7jImQAQnZu44hqYBUUAg7hbPb8f5Rb3DViA21Y4ukJ5RPiZiTa7hz9wxiHccvz5itB0sgx1wSmJa43ELz/hIWLF8d6NBtrg2MXC8KozWw2EwuGZQlfm0/8uGaX57chYX0hcsB+oiUaWkQYwYUvAfru7x9aUTaCw/SoiepHKAGGXqnmoF9J/ShHAz4qo8HIAzWb0UAwluOqslvurErpbftY0hC7QNW1dzffAzFVTOMQdgmM+EHXVynXv8b5s9ynX1Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ftls8K9lDhuvFWRZ/0oIcoDDpNXLDOhAYXO5N1M58BaCUhUaEV1Sn8WlZVcSZskG9QGjymYUMdgr5EY8Sg3hD/sBSMQqQ0Ypd/giWelVcLahCMHfVVLEYPaxsZStOz8pJlIR3iTyRXIP3PwNFe6GHeFYPA+AkU5pGsj93snFKdOtpV8DOa+Hij7S2RrHvvLVbz1TW76AAQoJ8gHuY8JrAPbbp/P1CTP4aQCaHJVuGPY5R2xbSxVGoXigWKPIA+5WqlNhzxHDJvv2fO4QBM2l9ugeUcwoaw4Vb546kHxzuZzcgy1K9eo5sV+wAJ788Vgwz9KY+o8jeOumeDAnFUOL6A==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 14 Oct 2021 09:33:27 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24.08.2021 12:50, Anthony PERARD wrote:
> After folowing patches, the recipe doesn't work anymore.
> - build: build everything from the root dir, use obj=$subdir
> - build: introduce if_changed_deps
That was some 20 patches ago - shouldn't all make goals continue to
work at every step?
> First patch mean that $(names) already have $(path), and the second
> one, the .*.d files are replaced by .*.cmd files which are much
> simpler to parse here.
>
> Also replace the makefile programming by a much simpler shell command.
>
> This doesn't check anymore if the source file exist, but that can be
> fixed by running `make clean`, and probably doesn't impact the
> calculation. `cloc` just complain that some files don't exist.
Not sure whether that's acceptable - Stefano, iirc it was you who
introduced this goal.
Jan
|
