[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH v7 32/51] build: Remove KBUILD_ specific from Makefile.host


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Date: Thu, 14 Oct 2021 15:18:50 +0100
  • Authentication-results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Thu, 14 Oct 2021 14:19:29 +0000
  • Ironport-data: A9a23:0DMFK6x0+HJKvmOmCBV6t+e6wSrEfRIJ4+MujC+fZmUNrF6WrkUOm zQfUGyBPPqJYWL3KIglYNy3/EsP7JPRmtJiGgI+rCAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAsLeNYYH1500s6w7dl2tcAbeWRWGthh /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt8l1y pZIkZmRcBkkHqDQu6NASxMHTj4raMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr 6ZBbmlQMFbT3Ipaw5riIgVors0lMMnsOpJZonx6xCvVJf0nXYrCU+PB4towMDIY250XTayGP 5NxhTxHMCmfbi10Hk4uDrExlealhHWjLyNakQfAzUYwyzeKl1EguFT3C/LOYcCDT8hRmkeep 0rF8n7/DxVcM8aQoRKa9lq8i+mJmjn0MKoCGbv9+vN0jVm7wm0IFAZQRVa9ueO+iEO1R5RYM UN80igkoLU29UerZsLgRBD+q3mB1jYdRNh4A+A88BuKyKff/0CeHGdsZjxcbN0rsucmSDps0 UWG9+4FHhQ27ufTEyjEsO7J83XiYkD5MFPuewcdSQlG5v3mgbgtgzLCUvUkTba/0YDqTGSYL y+xkAAygLAajMgu3qq9/Ezajz/EmqUlXjLZ9S2MATr7tlIRiJqNItXyswCCvKkowJOxFwHZ5 BA5d96iAPfi5H1nvBeGR/kRB/mX7vKBPSy0bbVHTsR5qWrFF5JOe+ltDNBCyKVBbplsldzBO ha7VeZtCHl7ZybCgUhfOdPZNijS5fK8fekJr9iNBja0XrB/dRWc4AZlblOK0mbmnSAEyP9kZ c7GKZjzXChEUcyLKQZaoc9GjNfHIQhklAvuqW3TlUz7gdJymlbEIVv6DLd+Rr9gt/7VyOkk2 91eK9GL231ivB7WOUHqHXooBQlSdxATXMmuw+QOL7LrClc2SQkJVq6KqZt8KtMNokigvrqRl p1LchQDkwSXaLyuAVjiV02Pn5u0Bs8k9yhlbXJ8VbtqslB6CbuSAG4kX8NfVdEaGCZLlpaYl tEJJJeNBOphUDPC92hPZJXxttU6Jh+qmRiPL2yuZz1mJ8xsQAnA+9nFeArz9XZRUnrr5JVm+ 7DwhBnGRZcjRhh5CJqEYvyY0F7s72MWn/h/XhWUL4ALKlns6oVjNwf4kuQzf5MXMRzGyzbDj 1SWDB4UqPPjuYgw9NWV16mIo53wS7l1H1ZAHnmd5rGzbHGI8m2myI5GceCJYTGCCz+kpPT8P b1YlqiuPucGkVBGt5tHP4xqla9utcHyo7J6zxh/GCmZZVqcFb49cGKN2tNCt/MRy+YB6xe2Q E+G5vJTJa6NZJH+CFcUKQcoMraD2PUTlmWA5Pg5Ohyntip+/b7BWkROJRiczidaKeItYo8ix O4gvu8Q6hC+1UV2YorX0HgM+jTeNGEEXoUmqooeUd3ihQccw11fZYDRV33t65aVZtQQakQnL 1d4XkYZa2iwEqYaT0cOKA==
  • Ironport-hdrordr: A9a23:xwOlGKn8hg/e8nZvorJZdIZ8wCDpDfIs3DAbv31ZSRFFG/Fxl6 iV8sjz8SWE7Ar5OUtQ/OxoV5PsfZqxz/JICMwqTNCftWrdyQmVxeNZjbcKqgeIc0aVygce79 YCT0EXMqyXMbEQt6fHCWeDfOod/A==
  • Ironport-sdr: bko/flN8xlLEW1VlFnKSOPjIuBt74HoOMoWHBST6ItBMu7xwaqQvaDrwmCKuIIRccDuc85H4A1 3qRjmFjiZyaGJTrIENcbadb554eDWFxlIVJ+dL1a/Q4/jTfOkkeF9GvK0P7qh5PIuBB5n8NOlQ YSShk1hLAnWPaLtdWfMr+c3Kqx+PJ0dLh0TtWBYyeK6UNnob6t61Dhvjqw8KHnc/HLXKr7IFB3 +SH4CBHI0SP3Gd7nL8IES0HQ6iL91TABWMDM7k8g2bUeAvTFCqG8BWFA0krWEMIo4sxDotZ8Gy czKjdxHZZXRF0yF+4LP8vpg6
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Mon, Oct 11, 2021 at 05:47:29PM +0200, Jan Beulich wrote:
> On 24.08.2021 12:50, Anthony PERARD wrote:
> > This will allow $(HOSTCFLAGS) to actually be used when building
> > programmes for the build-host.
> > 
> > The other variable don't exist in our build system.
> > 
> > Also remove $(KBUILD_EXTMOD) since it should always be empty.
> > 
> > Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> 
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> I wonder though whether their use of KBUILD_ prefixes doesn't match
> our XEN_ ones (e.g. KBUILD_CFLAGS vs XEN_CFLAGS), in which case
> replacing rather than stripping might be the way to go.

Well, at the moment, HOSTCFLAGS is defined in Config.mk, and xen/ makes
use of it. I don't think the other variable that I strip KBUILD_ from
exist, so maybe for those, changing prefix for XEN_ would be fine.
But for HOSTCFLAGS, I think we would want a new patch to set it in
xen/Makefile, and use it in xen/. But I don't think we need to spend
time on it at the moment.

Thanks,

-- 
Anthony PERARD



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.