[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/6] xen: introduce XEN_DOMCTL_CDF_directmap
- To: Penny Zheng <Penny.Zheng@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 15 Oct 2021 12:08:55 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jUDAo3tVpGKKJeF98JoZ41MZHO9meDQxahh0ucIWiv8=; b=N+cbx/y3muq/gO1XJai1MzyE0PSLbFeHR+1UHcAkA81e/x+mVHv6Pl25AHGtgKTeHHsxMWmY55J5C7v8cWFlD6dxnorzpx+09ydWeJOu7bwdytFKDFNYN1RpeEWpbsjJ5gwa9KCbEwamRQgh+C+kmvTYG6dgVm7arVqu1W0vMD2bRJNYQHNqBcvfuJx6E5iEG7nzMbtpq+IBYECpp7T3vpaZkc7QDaKY+UAyx4Q3jMAztzXDqbCIsAYwRJPHtOCFbhPnWwz44DF3amxsiMVtD0Vo8fUHh/KY/8YIet+F63DlVjPmibigvALVI6x8q+NtlqQZC6+Cn+Qs7fX3zObRBA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IYjWyZXIyfXQ2mJixILjYZGFB3b0r26npNclY368PMcSUcbnA74auipC7cO+hEYICcS3JJX4OgZEiZDi9O0lfzl37eg01i1L1Kn6Vp5f2fNdNeiVwvr7qq75HMtCTdU3F79+y2/NJYbdwUdoTuOqa+PZox5TVxQmCQDMI3DCb2d1iiCIKaKqCoshpgR0PAA7pCLE26er/P8iUbaJLxHHDp1wpETC0MI7uSGeDHuwEcxxGPYMe6ahbi2oect7Q59LFx3IWc9XnDSCEdCADvjE4KTb/LlCJRzKhCg7dNlEyIKdzTOi6YStecx+SRbIWVWNgd3/auqovkTdF2J2e+LCWA==
- Authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=suse.com;
- Cc: Wei Chen <Wei.Chen@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>
- Delivery-date: Fri, 15 Oct 2021 10:09:04 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 15.10.2021 11:59, Penny Zheng wrote:
>> From: Jan Beulich <jbeulich@xxxxxxxx>
>> Sent: Friday, October 15, 2021 4:47 PM
>>
>> On 15.10.2021 05:09, Penny Zheng wrote:
>>> xen/arch/arm/domain.c | 3 ++-
>>> xen/arch/arm/domain_build.c | 4 +++-
>>> xen/common/domain.c | 3 ++-
>>> xen/include/asm-arm/domain.h | 4 ++-- xen/include/public/domctl.h |
>>> 4 +++-
>>> 5 files changed, 12 insertions(+), 6 deletions(-)
>>
>> You clearly had to re-base over the XEN_DOMCTL_CDF_vpmu addition. I think
>> just like that change (which I'd expect you to have looked at while doing the
>> re-base) you also need to at least fiddle with OCaml's domain_create_flag, to
>> keep the ABI check there happy.
>>
>
> The patch serie is based on the staging branch with an extra commit "
> Revert "xen/domctl: Introduce XEN_DOMCTL_CDF_vpci flag", which
> Is already been pushed to community for review.(
> https://lists.xenproject.org/archives/html/xen-devel/2021-10/msg00822.html)
I was assuming so, and hence I didn't also refer you to the vPCI
patch, which you could also have used for reference. I guess my
primary problem here is that I can't see what you're trying to tell
me.
Jan
|
