[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI support for ARM.

  • To: Ian Jackson <iwj@xxxxxxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Fri, 15 Oct 2021 12:18:59 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7vG7th2ViwhqEtFmOJxS6pXO2/ai+G8iXQXhuBqqK2A=; b=HYNcMjhFbI6hDYtlSnZ5+s3fjVvV5THMr/jlF8r5Yg5xMYMUtxp8nplGQZ20SuedVU7bk70qYrODIAgBCKjBnUV2IWHjka1fMF6hob3N5qSGpewvtYD2c0Nklu+rK7deeUnoemLgtz93l36vuMBebkorbAVGcOMP1iCouYw0QEtToL+FGU8sFFk0oCr2xsu52p0673IKPe+Ry22kVNchO4rWvCIgS/V5Xzc0qV3OVVdOtDe5kkZ1O0GoJ+kb7Awc1iYbHWieIGzTD2+2uL3wQLGS7ng29dYsDez16NYfdBxlI+rWCgIPrUfCZAWTAl44PKFqNKNsfYCJ+3nLa2RdSA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QTIl/22J6k9ckUcMak60hrJKhSXey+letY2S9PpCTRlxjk9tBoZAQB+x4IWaNKoHuxHSJMhuzZUKKRN/zD6vpCYn2liEwTfRubVZhUQ1v54ELqJcMKP+aHL5hUY0gprW19NTDZix7vjgqBmWHCgVhEmnhOH3jikO8p9LiB6/cA4UFbso+gLqQwt+825ClWE8PxjqajKJtjFNgYm7o1pn1lYq9d/aNrBL6dd0fCVGfm6M7QTm11IG2NtNSQJRKu19tMvQlQEZTltXGtAIqVwGHg0VVzMFUToWVf/qFpTarXQjHKNtMI4ME0o0Mk1+pCb71HGF61dLDxfFSp5/adToog==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Rahul Singh <Rahul.Singh@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Paul Durrant <paul@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Fri, 15 Oct 2021 10:19:09 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 15.10.2021 12:14, Ian Jackson wrote:
> Bertrand Marquis writes ("Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 
> virtual PCI support for ARM."):
>>> On 15 Oct 2021, at 09:00, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>>> The latter is fine to be put here (i.e. FTAOD I'm fine with it
>>> staying here). For the former I even question its original placement
>>> in asm-x86/pci.h: It's not generally correct as per the PCI spec, as
>>> the bus portion of the address can be anywhere from 1 to 8 bits. And
>>> in fact there is a reason why this macro was/is used in only a
>>> single place, but not e.g. in x86'es handling of physical MCFG. It
>>> is merely an implementation choice in vPCI that the entire segment 0
>>> has a linear address range covering all 256 buses. Hence I think
>>> this wants to move to xen/vpci.h and then perhaps also be named
>> On previous version it was request to renamed this to ECAM and agreed
>> to put is here. Now you want me to rename it to VPCI and move it again.
>> I would like to have a confirmation that this is ok and the final move if 
>> possible.
>> @Roger can you confirm this is what is wanted ?
> I think Roger is not available today I'm afraid.
> Bertrand, can you give me a link to the comment from Roger ?
> Assuming that it says what I think it will say:
> I think the best thing to do will be to leave the name as it was in
> the most recent version of your series.  I don't think it makes sense
> to block this patch over a naming disagreement.  And it would be best
> to minimise unnecessary churn.
> I would be happy to release-ack a name change (perhaps proposed bo Jan
> or Roger) supposing that that is the ultimate maintainer consensus.
> Jan, would that approach be OK with you ?

Well, yes, if a subsequent name change is okay, then I could live with
that. I'd still find it odd to rename a function immediately after it
already got renamed. As expressed elsewhere, I suspect in his request
Roger did not pay attention to a use of the function in non-ECAM code.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.