[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI support for ARM.

  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
  • Date: Fri, 15 Oct 2021 10:33:54 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5eFMa+E8JcpKIaxl768vJ8cp10kxiTSJzeR6Cil4j/I=; b=layTUdSJ8fH7u7IoBt8e8b2qt53dUPVaUCHzICYdjUPo2fnGiFneP0fgAY1pVVGLK6K1gcO8SP/Zu4A6K8/A4aAlRPXM4Svj0GGDPtqPTdITzpA+swCDvVT1MFz7Qsck48QRuzTvqHzN1zO+XAGqJnMYtoHGsdvWkXIPnVbHrMC9kf3BS2zmCtPLiaw8TtlH39DUMWX7EGsJGC1unVU3DT99cHBCdg1fYKi1Qbx/TRyEYgVAG05v6muSuF7jn2NxFahc83HQg5oCpouAVa0VCQkZrlk94lmBkHe1i/XTYgkzPFZ6mrZq0J9dNWsAc9BQe+Tkorp8Ptk1TmkCnEnEuw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fsRqK49zvyscG3/mZeXzWC2wrz7GCSTXRanGjk4W0LVME/0h4v52fP/ptnhgYXfwuOeYxtD6WUARRZZRDJkzjGniO941zj9zMphjIC5eheS7IE60cwEFwfqosrD46DrDnbgNmpOieJbyLWpkg7a06SyWfVdb5ejkSN9sIY9WFrg5B3h9N+9MSNcrmr4kQ7fRrB6vvRbSkbIiwkXdyXEWQv0FpXnWmKb/F0dgWrUEeyZoXNFyG3zKMkLEyqqqKe/WXutQQBq3DklU6BotuK5+gRewY63b4edoTnXXfLco4jJA2Mn3pahKtOZhOOvp+JzrOZHjE0ugCUPjAL0I0ri1SA==
  • Authentication-results-original: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Rahul Singh <Rahul.Singh@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Paul Durrant <paul@xxxxxxx>, Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Fri, 15 Oct 2021 10:34:16 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHXwQrjS6mPrKT7Q06z3N66FcsDAKvTvGsAgAAWOICAAAj6gIAAApmA
  • Thread-topic: [PATCH v6 2/3] xen/arm: Enable the existing x86 virtual PCI support for ARM.

> On 15 Oct 2021, at 11:24, Jan Beulich <jbeulich@xxxxxxxx> wrote:
> On 15.10.2021 11:52, Bertrand Marquis wrote:
>>> On 15 Oct 2021, at 09:32, Roger Pau Monné <roger.pau@xxxxxxxxxx> wrote:
>>> On Thu, Oct 14, 2021 at 03:49:50PM +0100, Bertrand Marquis wrote:
>>>> @@ -752,6 +752,19 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>>>>    check_pdev(pdev);
>>>> +#ifdef CONFIG_ARM
>>>> +    /*
>>>> +     * On ARM PCI devices discovery will be done by Dom0. Add vpci 
>>>> handler when
>>>> +     * Dom0 inform XEN to add the PCI devices in XEN.
>>>> +     */
>>>> +    ret = vpci_add_handlers(pdev);
>>>> +    if ( ret )
>>>> +    {
>>>> +        printk(XENLOG_ERR "Setup of vPCI failed: %d\n", ret);
>>>> +        goto out;
>>>> +    }
>>>> +#endif
>>> I think vpci_add_handlers should be called after checking that
>>> pdev->domain is != NULL, so I would move this chunk a bit below.
>> On arm this would prevent the dom0less use case or to have the PCI
>> bus enumerated from an other domain.
>> @oleksandr: can you comment on this one, you might have a better
>> answer than me on this ?
> Well, without Xen doing the enumeration, some other entity would need
> to do so, including the reporting to Xen. Obviously without a Dom0 it
> would be ambiguous which domain to assign the device to; perhaps it
> should be the caller in this case? That would make that caller domain
> a pseudo-hwdom though, as far as PCI is concerned, which may not be
> desirable according to my (limited) understanding of dom0less.

This is not really related to this patch but the plan is the following:
- enumeration would have to be done by the firmware or boot loader before
- xen will have some code to detect PCI devices
- dom0less can be used to assign PCI devices to guest

Anyway does not change the fact that this must be called when domain is not 
NULL and I will fix that.

>>>> @@ -784,6 +797,9 @@ out:
>>>>                   &PCI_SBDF(seg, bus, slot, func));
>>>>        }
>>>>    }
>>>> +    else if ( pdev )
>>>> +        pci_cleanup_msi(pdev);
>>> I'm slightly lost at why you add this chunk, is this strictly related
>>> to the patch?
>> This was discussed a lot in previous version of the patch and
>> requested by Stefano. The idea here is that as soon as handlers
>> are added some bits might be modified in the PCI config space
>> leading possibly to msi interrupts. So it is safer to cleanup on the
>> error path. For references please see discussion on v4 and v5 where
>> this was actually added (to much references as the discussion was
>> long so here [1] and [2] are the patchwork thread).
>> [1] 
>> https://patchwork.kernel.org/project/xen-devel/patch/9bdca2cda5d2e83f94dc2423e55714273539760a.1633540842.git.rahul.singh@xxxxxxx/
>> [2] 
>> https://patchwork.kernel.org/project/xen-devel/patch/f093de681c2560a7196895bcd666ef8840885c1d.1633340795.git.rahul.singh@xxxxxxx/
> The addition of this call has repeatedly raised questions. This is a
> good indication that sufficient discussion thereof has been lacking
> from the patch description.

Yes and I will remove it as it only impacts x86 right now.
If this is needed, we will have to do it while adding MSI support on Arm.


> Jan



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.